From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:33651 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757246AbcJXHDU (ORCPT ); Mon, 24 Oct 2016 03:03:20 -0400 Received: by mail-wm0-f68.google.com with SMTP id d128so8336635wmf.0 for ; Mon, 24 Oct 2016 00:03:19 -0700 (PDT) Date: Mon, 24 Oct 2016 09:03:16 +0200 From: Daniel Vetter To: Daniel Stone Cc: intel-gfx@lists.freedesktop.org, Daniel Vetter , ville.syrjala@intel.com, stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm: i915: Wait for fences on new fb, not old Message-ID: <20161024070316.GA20761@phenom.ffwll.local> References: <20161021144454.6288-1-daniels@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161021144454.6288-1-daniels@collabora.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Oct 21, 2016 at 03:44:54PM +0100, Daniel Stone wrote: > The previous code would wait for fences on the framebuffer from the old > plane state to complete, rather than the new, so you would see tearing > everywhere. Fix this to wait on the new state before we make it active. > > Signed-off-by: Daniel Stone > Fixes: 94f050246b42 ("drm/i915: nonblocking commit") > Cc: stable@vger.kernel.org > Cc: Daniel Vetter > Cc: Maarten Lankhorst Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index e5ad101..1bdef9e 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -14292,7 +14292,7 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state) > > for_each_plane_in_state(state, plane, plane_state, i) { > struct intel_plane_state *intel_plane_state = > - to_intel_plane_state(plane_state); > + to_intel_plane_state(plane->state); > > if (!intel_plane_state->wait_req) > continue; > -- > 2.9.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch