From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: intel-gfx@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Mika Kahola <mika.kahola@intel.com>,
bruno.pagani@ens-lyon.org,
Daniel J Blueman <daniel.blueman@gmail.com>,
Joseph Yasi <joe.yasi@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Fix cdclk vs. dev_cdclk mess when not recomputing things
Date: Sat, 29 Oct 2016 00:30:50 +0300 [thread overview]
Message-ID: <20161028213050.GM4617@intel.com> (raw)
In-Reply-To: <1477688748.2167.17.camel@tiscali.nl>
On Fri, Oct 28, 2016 at 11:05:48PM +0200, Paul Bolle wrote:
> On Fri, 2016-10-28 at 19:59 +0300, ville.syrjala@linux.intel.com wrote:
> > Fixes: 1a617b77658e ("drm/i915: Keep track of the cdclk as if all crtc's were active.")
>
> Obviously, I'm pretty happy with this patch. One question though: this
> fixes a commit that shipped in v4.6. Do you have any idea why this
> issue apparently never surfaced before v4.8?
Pop quiz time, eh? :)
I think it was probably due to
commit 44d1240d006c9cd0249263b5449c8e4752500f6a
Author: Marek Szyprowski <m.szyprowski@samsung.com>
Date: Mon Jun 13 11:11:26 2016 +0200
drm: add generic zpos property
If you want want to grade my answer all you have to do is revert that
on 4.8 and see what happens. Might be interesting to see if I'm right
actually since the link between the WARN and that commit isn't entirely
obvious.
--
Ville Syrj�l�
Intel OTC
next prev parent reply other threads:[~2016-10-28 21:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 16:59 [PATCH] drm/i915: Fix cdclk vs. dev_cdclk mess when not recomputing things ville.syrjala
2016-10-28 21:05 ` Paul Bolle
2016-10-28 21:30 ` Ville Syrjälä [this message]
2016-10-28 21:38 ` Paul Bolle
2016-10-28 22:01 ` Ville Syrjälä
2016-11-01 8:57 ` Maarten Lankhorst
2016-11-01 9:07 ` Paul Bolle
2016-11-01 12:41 ` Ville Syrjälä
2016-11-01 12:40 ` Ville Syrjälä
2016-11-01 12:53 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028213050.GM4617@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=bruno.pagani@ens-lyon.org \
--cc=daniel.blueman@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joe.yasi@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mika.kahola@intel.com \
--cc=pebolle@tiscali.nl \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).