From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com ([192.55.52.115]:53632 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751691AbcJ1Va4 (ORCPT ); Fri, 28 Oct 2016 17:30:56 -0400 Date: Sat, 29 Oct 2016 00:30:50 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Paul Bolle Cc: intel-gfx@lists.freedesktop.org, Maarten Lankhorst , Mika Kahola , bruno.pagani@ens-lyon.org, Daniel J Blueman , Joseph Yasi , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: Fix cdclk vs. dev_cdclk mess when not recomputing things Message-ID: <20161028213050.GM4617@intel.com> References: <1477673960-3274-1-git-send-email-ville.syrjala@linux.intel.com> <1477688748.2167.17.camel@tiscali.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1477688748.2167.17.camel@tiscali.nl> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Oct 28, 2016 at 11:05:48PM +0200, Paul Bolle wrote: > On Fri, 2016-10-28 at 19:59 +0300, ville.syrjala@linux.intel.com wrote: > > Fixes: 1a617b77658e ("drm/i915: Keep track of the cdclk as if all crtc's were active.") > > Obviously, I'm pretty happy with this patch. One question though: this > fixes a commit that shipped in v4.6. Do you have any idea why this > issue apparently never surfaced before v4.8? Pop quiz time, eh? :) I think it was probably due to commit 44d1240d006c9cd0249263b5449c8e4752500f6a Author: Marek Szyprowski Date: Mon Jun 13 11:11:26 2016 +0200 drm: add generic zpos property If you want want to grade my answer all you have to do is revert that on 4.8 and see what happens. Might be interesting to see if I'm right actually since the link between the WARN and that commit isn't entirely obvious. -- Ville Syrj�l� Intel OTC