From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:57110 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932371AbcKMLSe (ORCPT ); Sun, 13 Nov 2016 06:18:34 -0500 Date: Sun, 13 Nov 2016 12:18:44 +0100 From: Greg KH To: James Hogan Cc: stable@vger.kernel.org, Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Ralf Baechle , linux-mips@linux-mips.org, kvm@vger.kernel.org Subject: Re: [BACKPORT PATCH 3.17..4.4] KVM: MIPS: Drop other CPU ASIDs on guest MMU changes Message-ID: <20161113111844.GC10476@kroah.com> References: <20161109144544.16608-1-james.hogan@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161109144544.16608-1-james.hogan@imgtec.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Nov 09, 2016 at 02:45:44PM +0000, James Hogan wrote: > commit 91e4f1b6073dd680d86cdb7e42d7cccca9db39d8 upstream. > > When a guest TLB entry is replaced by TLBWI or TLBWR, we only invalidate > TLB entries on the local CPU. This doesn't work correctly on an SMP host > when the guest is migrated to a different physical CPU, as it could pick > up stale TLB mappings from the last time the vCPU ran on that physical > CPU. > > Therefore invalidate both user and kernel host ASIDs on other CPUs, > which will cause new ASIDs to be generated when it next runs on those > CPUs. > > We're careful only to do this if the TLB entry was already valid, and > only for the kernel ASID where the virtual address it mapped is outside > of the guest user address range. > > Signed-off-by: James Hogan > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc: Ralf Baechle > Cc: linux-mips@linux-mips.org > Cc: kvm@vger.kernel.org > Cc: # 3.17.x- > [james.hogan@imgtec.com: Backport to 3.17..4.4] > Signed-off-by: James Hogan > --- > Unfortunately the original commit went in to v4.4.25 as commit > d450527ad04a, without fixing up the references to tlb_lo[0/1] to > tlb_lo0/1 which broke the MIPS KVM build, and I didn't twig that I > already had a correct backport outstanding (sorry!). That commit should > be reverted before applying this backport to 4.4. Thanks for this, now fixed up. greg k-h