From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Amitkumar Karwar <akarwar@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
<linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org, Cathy Luo <cluo@marvell.com>,
security@kernel.org, stable@vger.kernel.org,
Brian Norris <briannorris@chromium.org>
Subject: Re: mwifiex: printk() overflow with 32-byte SSIDs
Date: Thu, 17 Nov 2016 11:18:16 +0000 (UTC) [thread overview]
Message-ID: <20161117111816.227EE61626@smtp.codeaurora.org> (raw)
In-Reply-To: <1478658504-31045-1-git-send-email-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> SSIDs aren't guaranteed to be 0-terminated. Let's cap the max length
> when we print them out.
>
> This can be easily noticed by connecting to a network with a 32-octet
> SSID:
>
> [ 3903.502925] mwifiex_pcie 0000:01:00.0: info: trying to associate to
> '0123456789abcdef0123456789abcdef <uninitialized mem>' bssid
> xx:xx:xx:xx:xx:xx
>
> Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Cc: <stable@vger.kernel.org>
> Acked-by: Amitkumar Karwar <akarwar@marvell.com>
Patch applied to wireless-drivers.git, thanks.
fcd2042e8d36 mwifiex: printk() overflow with 32-byte SSIDs
--
https://patchwork.kernel.org/patch/9418369/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2016-11-17 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 2:28 [PATCH] mwifiex: printk() overflow with 32-byte SSIDs Brian Norris
2016-11-09 7:51 ` Amitkumar Karwar
2016-11-09 22:20 ` Kalle Valo
2016-11-09 22:22 ` Brian Norris
2016-11-17 11:18 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117111816.227EE61626@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akarwar@marvell.com \
--cc=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=security@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).