From: Andre Noll <maan@tuebingen.mpg.de>
To: Eric Dumazet <edumazet@google.com>
Cc: "Duyck, Alexander H" <alexander.h.duyck@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"willemb@google.com" <willemb@google.com>,
"jslaby@suse.cz" <jslaby@suse.cz>,
"davem@davemloft.net" <davem@davemloft.net>,
"yibyang@cisco.com" <yibyang@cisco.com>
Subject: Re: Linux 4.4.34
Date: Tue, 22 Nov 2016 18:55:04 +0100 [thread overview]
Message-ID: <20161122175504.GD19939@tuebingen.mpg.de> (raw)
In-Reply-To: <CANn89iLdtfoYDVoszduyKCpmZpYcpV2=UnwbjAzH0G08nzNwbw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
On Tue, Nov 22, 09:46, Eric Dumazet wrote
> This is an aliasing problem.
> Tom code is hard to read and understand.
>
> Andre, could you try :
>
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 69e4463a4b1b..b045980faaea 100644
> --- a/net/core/flow_dissector.c
> +++ b/net/core/flow_dissector.c
> @@ -157,6 +157,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
> memcpy(key_eth_addrs, ð->h_dest, sizeof(*key_eth_addrs));
> }
>
> + barrier();
> again:
> switch (proto) {
> case htons(ETH_P_IP): {
This patch on top of v4.4.34 makes no difference: I'm still getting
the panic in eth_type_trans().
Andre
--
Max Planck Institute for Developmental Biology
Spemannstraße 35, 72076 Tübingen, Germany. Phone: (+49) 7071 601 829
http://people.tuebingen.mpg.de/maan/
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-11-22 17:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 9:28 Linux 4.4.34 Greg KH
2016-11-21 9:28 ` Greg KH
2016-11-22 16:59 ` Andre Noll
2016-11-22 17:06 ` Greg KH
2016-11-22 17:14 ` Eric Dumazet
2016-11-22 17:38 ` Andre Noll
2016-11-22 17:41 ` Duyck, Alexander H
2016-11-22 17:46 ` Eric Dumazet
2016-11-22 17:55 ` Andre Noll [this message]
2016-11-22 17:56 ` Eric Dumazet
2016-11-22 18:03 ` Duyck, Alexander H
2016-11-22 18:06 ` Andre Noll
2016-11-22 18:08 ` Duyck, Alexander H
2016-11-22 18:18 ` Eric Dumazet
2016-11-22 18:22 ` Andre Noll
2016-11-22 17:22 ` Andre Noll
2016-11-22 17:26 ` Eric Dumazet
2016-11-22 17:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122175504.GD19939@tuebingen.mpg.de \
--to=maan@tuebingen.mpg.de \
--cc=alexander.h.duyck@intel.com \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=willemb@google.com \
--cc=yibyang@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).