From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-pg0-f65.google.com ([74.125.83.65]:36301 "EHLO
        mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750809AbcKZGjv (ORCPT
        <rfc822;stable@vger.kernel.org>); Sat, 26 Nov 2016 01:39:51 -0500
Date: Sat, 26 Nov 2016 15:38:32 +0900
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Takashi Iwai <tiwai@suse.de>,
        Hyeoncheol Lee <cheol.lee@lge.com>, yjay.kim@lge.com,
        Sangseok Lee <sangseok.lee@lge.com>,
        Hugh Dickins <hughd@google.com>, stable@vger.kernel.org
Subject: Re: [PATCH v3 2/3] zram: revalidate disk under init_lock
Message-ID: <20161126063832.GB521@tigerII>
References: <1480062914-25556-1-git-send-email-minchan@kernel.org>
 <1480062914-25556-3-git-send-email-minchan@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1480062914-25556-3-git-send-email-minchan@kernel.org>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>


Hi,

On (11/25/16 17:35), Minchan Kim wrote:
> [1] moved revalidate_disk call out of init_lock to avoid lockdep
> false-positive splat. However, [2] remove init_lock in IO path
> so there is no worry about lockdep splat. So, let's restore it.
> This patch need to set BDI_CAP_STABLE_WRITES atomically in
> next patch.

can we break that dependency on the next patch if we would
set BDI_CAP_STABLE_WRITES when we allocate the queue?

	queue->backing_dev_info.capabilities |= BDI_CAP_CGROUP_WRITEBACK;

	-ss