From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:34575 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750723AbcK0NC0 (ORCPT ); Sun, 27 Nov 2016 08:02:26 -0500 Date: Sun, 27 Nov 2016 22:01:04 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org, Takashi Iwai , Hyeoncheol Lee , yjay.kim@lge.com, Sangseok Lee , Hugh Dickins , stable@vger.kernel.org Subject: Re: [PATCH v3 3/3] zram: support BDI_CAP_STABLE_WRITES Message-ID: <20161127130104.GA4919@tigerII> References: <1480062914-25556-1-git-send-email-minchan@kernel.org> <1480062914-25556-4-git-send-email-minchan@kernel.org> <20161126063701.GA521@tigerII> <20161126144104.GA2189@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161126144104.GA2189@blaptop> Sender: stable-owner@vger.kernel.org List-ID: On (11/26/16 23:41), Minchan Kim wrote: [..] > > > mutex_lock(&bdev->bd_mutex); > > > > why not set it just once, when we allocate queue/disk and configure both > > of them: in zram_add() > > I should have mentioned the reason. > The revalidate_disk reset the BDI_CAP_STABLE_WRITES. aha. either sets or clears it in blk_integrity_revalidate(), now I see it. -ss