From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Romain Perier <romain.perier@free-electrons.com>
Cc: Arnaud Ebalard <arno@natisbad.org>,
linux-crypto@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] crypto: marvell - Don't copy hash operation twice into the SRAM
Date: Fri, 2 Dec 2016 17:30:02 +0100 [thread overview]
Message-ID: <20161202173002.23ee6fdb@bbrezillon> (raw)
In-Reply-To: <20161202160551.9940-2-romain.perier@free-electrons.com>
On Fri, 2 Dec 2016 17:05:50 +0100
Romain Perier <romain.perier@free-electrons.com> wrote:
> No need to copy the template of an hash operation twice into the SRAM
> from the step function.
>
> Fixes: commit 85030c5168f1 ("crypto: marvell - Add support for chai...")
> Signed-off-by: Romain Perier <romain.perier@free-electrons.com>
Oh, and please add
Cc: <stable@vger.kernel.org>
to both patches.
> ---
> drivers/crypto/marvell/hash.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/crypto/marvell/hash.c b/drivers/crypto/marvell/hash.c
> index 2a92605..fbbcbf8 100644
> --- a/drivers/crypto/marvell/hash.c
> +++ b/drivers/crypto/marvell/hash.c
> @@ -172,9 +172,6 @@ static void mv_cesa_ahash_std_step(struct ahash_request *req)
> for (i = 0; i < digsize / 4; i++)
> writel_relaxed(creq->state[i], engine->regs + CESA_IVDIG(i));
>
> - mv_cesa_adjust_op(engine, &creq->op_tmpl);
> - memcpy_toio(engine->sram, &creq->op_tmpl, sizeof(creq->op_tmpl));
> -
> if (creq->cache_ptr)
> memcpy_toio(engine->sram + CESA_SA_DATA_SRAM_OFFSET,
> creq->cache, creq->cache_ptr);
next prev parent reply other threads:[~2016-12-02 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 16:05 [PATCH 0/2] CESA: Fixes for STD ahash requests Romain Perier
2016-12-02 16:05 ` [PATCH 1/2] crypto: marvell - Don't copy hash operation twice into the SRAM Romain Perier
2016-12-02 16:21 ` Boris Brezillon
2016-12-02 16:30 ` Boris Brezillon [this message]
2016-12-02 16:05 ` [PATCH 2/2] crypto: marvell - Don't corrupt state of an STD req for re-stepped ahash Romain Perier
2016-12-02 16:21 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202173002.23ee6fdb@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=arno@natisbad.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-crypto@vger.kernel.org \
--cc=romain.perier@free-electrons.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).