From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Steven Allen <steven@stebalien.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] zram: restrict add/remove attributes to root only
Date: Sun, 4 Dec 2016 21:49:36 +0900 [thread overview]
Message-ID: <20161204124936.GB4520@tigerII.localdomain> (raw)
In-Reply-To: <20161204112820.GA24757@kroah.com>
On (12/04/16 12:28), Greg KH wrote:
> > [..]
> >
> > > Why can't a normal user read the attribute? Does a read actually modify
> > > something?
> >
> > yes, it does.
>
> Oh that's totally and completely broken then.
>
> Reading from a sysfs file should NEVER cause side affects to the system.
> Please fix up this api.
we have a mechanism for such API changes -- there is a bunch of deprecated
sysfs attrs that we will remove in 4.11; so I'll mark hot_add/hot_remove
as deprecated and switch to char device (as you suggested). thanks.
-ss
prev parent reply other threads:[~2016-12-04 13:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 2:35 [PATCH] zram: restrict add/remove attributes to root only Sergey Senozhatsky
2016-12-04 10:28 ` Greg KH
2016-12-04 10:52 ` Sergey Senozhatsky
2016-12-04 11:28 ` Greg KH
2016-12-04 11:41 ` Sergey Senozhatsky
2016-12-04 11:55 ` Greg KH
2016-12-04 12:08 ` Sergey Senozhatsky
2016-12-04 12:49 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161204124936.GB4520@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=stable@vger.kernel.org \
--cc=steven@stebalien.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox