From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Steven Allen <steven@stebalien.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCHv2] zram: restrict add/remove attributes to root only
Date: Tue, 6 Dec 2016 00:57:28 +0900 [thread overview]
Message-ID: <20161205155728.GA5014@tigerII.localdomain> (raw)
In-Reply-To: <20161205125719.GE19696@kroah.com>
On (12/05/16 13:57), Greg KH wrote:
> > +/*
> > + * NOTE: hot_add attribute is not the usual read-only sysfs
> > + * attribute. In a sence that reading from this file does alter
> > + * the state of your system -- it creates a new un-initialized
> > + * zram device and returns back this device's device_id (or an
> > + * error code if it fails to create a new device).
> > + */
> > static struct class_attribute zram_control_class_attrs[] = {
> > - __ATTR_RO(hot_add),
> > - __ATTR_WO(hot_remove),
> > + __ATTR(hot_add, 0400, hot_add_show, NULL),
> > + __ATTR(hot_remove, 0200, NULL, hot_remove_store),
>
> You can leave hot_remove as __ATTR_WO(), right?
yes. I changed it deliberately.
> Please do so if at all possible.
ok.
-ss
next prev parent reply other threads:[~2016-12-05 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 12:44 [PATCHv2] zram: restrict add/remove attributes to root only Sergey Senozhatsky
2016-12-05 12:57 ` Greg KH
2016-12-05 15:57 ` Sergey Senozhatsky [this message]
2016-12-05 15:58 ` [PATCHv3] " Sergey Senozhatsky
2016-12-05 16:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205155728.GA5014@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=stable@vger.kernel.org \
--cc=steven@stebalien.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).