* [PATCH 02/18] drm/i915/dsi: Fix chv_exec_gpio disabling the GPIOs it is setting [not found] <20161201202925.12220-1-hdegoede@redhat.com> @ 2016-12-01 20:29 ` Hans de Goede 2016-12-07 17:48 ` Ville Syrjälä 0 siblings, 1 reply; 2+ messages in thread From: Hans de Goede @ 2016-12-01 20:29 UTC (permalink / raw) To: Daniel Vetter, Jani Nikula, Ville Syrjälä Cc: intel-gfx, dri-devel, Hans de Goede, stable, Jani Nikula Set the CHV_GPIO_GPIOEN bit when updating GPIOs from chv_exec_gpio. Fixes: a0a6d4ffd2ad ("drm/i915/dsi: add support for gpio elements on CHV") Cc: stable@vger.kernel.org Cc: Jani Nikula <jani.nikula@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c index 579d2f5..47cd1b2 100644 --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c @@ -300,7 +300,8 @@ static void chv_exec_gpio(struct drm_i915_private *dev_priv, mutex_lock(&dev_priv->sb_lock); vlv_iosf_sb_write(dev_priv, port, cfg1, 0); vlv_iosf_sb_write(dev_priv, port, cfg0, - CHV_GPIO_GPIOCFG_GPO | CHV_GPIO_GPIOTXSTATE(value)); + CHV_GPIO_GPIOEN | CHV_GPIO_GPIOCFG_GPO | + CHV_GPIO_GPIOTXSTATE(value)); mutex_unlock(&dev_priv->sb_lock); } -- 2.9.3 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 02/18] drm/i915/dsi: Fix chv_exec_gpio disabling the GPIOs it is setting 2016-12-01 20:29 ` [PATCH 02/18] drm/i915/dsi: Fix chv_exec_gpio disabling the GPIOs it is setting Hans de Goede @ 2016-12-07 17:48 ` Ville Syrjälä 0 siblings, 0 replies; 2+ messages in thread From: Ville Syrjälä @ 2016-12-07 17:48 UTC (permalink / raw) To: Hans de Goede Cc: Daniel Vetter, Jani Nikula, intel-gfx, dri-devel, stable, Jani Nikula On Thu, Dec 01, 2016 at 09:29:09PM +0100, Hans de Goede wrote: > Set the CHV_GPIO_GPIOEN bit when updating GPIOs from chv_exec_gpio. > > Fixes: a0a6d4ffd2ad ("drm/i915/dsi: add support for gpio elements on CHV") > Cc: stable@vger.kernel.org > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Ville Syrj�l� <ville.syrjala@linux.intel.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > Reviewed-by: Ville Syrj�l� <ville.syrjala@linux.intel.com> Pushed to dinq. Thanks for the patch. > --- > drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > index 579d2f5..47cd1b2 100644 > --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > @@ -300,7 +300,8 @@ static void chv_exec_gpio(struct drm_i915_private *dev_priv, > mutex_lock(&dev_priv->sb_lock); > vlv_iosf_sb_write(dev_priv, port, cfg1, 0); > vlv_iosf_sb_write(dev_priv, port, cfg0, > - CHV_GPIO_GPIOCFG_GPO | CHV_GPIO_GPIOTXSTATE(value)); > + CHV_GPIO_GPIOEN | CHV_GPIO_GPIOCFG_GPO | > + CHV_GPIO_GPIOTXSTATE(value)); > mutex_unlock(&dev_priv->sb_lock); > } > > -- > 2.9.3 -- Ville Syrj�l� Intel OTC ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-07 17:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20161201202925.12220-1-hdegoede@redhat.com>
2016-12-01 20:29 ` [PATCH 02/18] drm/i915/dsi: Fix chv_exec_gpio disabling the GPIOs it is setting Hans de Goede
2016-12-07 17:48 ` Ville Syrjälä
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).