* Re: version 3.18.44 to 3.18.45 introduced a bug in "drivers/scsi/megaraid/megaraid_sas_base.c" [not found] <23B7B563BA4E9446B962B142C86EF24ADB6F24@CNMAILEX03.lenovo.com> @ 2016-12-13 16:08 ` Randy Dunlap 2016-12-13 16:30 ` Greg Kroah-Hartman 0 siblings, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2016-12-13 16:08 UTC (permalink / raw) To: Dashi DS1 Cao, linux-kernel@vger.kernel.org, linux-scsi, Greg Kroah-Hartman, stable [adding other lists + gregkh] On 12/13/16 02:56, Dashi DS1 Cao wrote: > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -1614,16 +1614,13 @@ megasas_queue_command(struct Scsi_Host *shost, struct scsi_cmnd *scmd) > goto out_done; > } > > - switch (scmd->cmnd[0]) { > - case SYNCHRONIZE_CACHE: > - /* > - * FW takes care of flush cache on its own > - * No need to send it down > - */ > + /* > + * FW takes care of flush cache on its own for Virtual Disk. > + * No need to send it down for VD. For JBOD send SYNCHRONIZE_CACHE to FW. > + */ > + if ((scmd->cmnd[0] == SYNCHRONIZE_CACHE) && MEGASAS_IS_LOGICAL(scmd)) { > scmd->result = DID_OK << 16; > goto out_done; > - default: > - break; > } > > if (instance->instancet->build_and_issue_cmd(instance, scmd)) { > > MEGASAS_IS_LOGICAL is defined to be a macro with '?' operator, which has a lower precedence than '&&'. > The macro should have been defined as: > --- a/drivers/scsi/megaraid/megaraid_sas.h > +++ b/drivers/scsi/megaraid/megaraid_sas.h > @@ -1823,7 +1823,7 @@ struct megasas_instance_template { > }; > > #define MEGASAS_IS_LOGICAL(scp) \ > - (scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1 > + ((scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1) > > #define MEGASAS_DEV_INDEX(inst, scp) \ > ((scp->device->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL) + \ > > Dashi Cao > -- ~Randy ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: version 3.18.44 to 3.18.45 introduced a bug in "drivers/scsi/megaraid/megaraid_sas_base.c" 2016-12-13 16:08 ` version 3.18.44 to 3.18.45 introduced a bug in "drivers/scsi/megaraid/megaraid_sas_base.c" Randy Dunlap @ 2016-12-13 16:30 ` Greg Kroah-Hartman 2016-12-13 16:33 ` Randy Dunlap 0 siblings, 1 reply; 5+ messages in thread From: Greg Kroah-Hartman @ 2016-12-13 16:30 UTC (permalink / raw) To: Randy Dunlap Cc: Dashi DS1 Cao, linux-kernel@vger.kernel.org, linux-scsi, stable On Tue, Dec 13, 2016 at 08:08:27AM -0800, Randy Dunlap wrote: > [adding other lists + gregkh] > > > On 12/13/16 02:56, Dashi DS1 Cao wrote: > > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > > @@ -1614,16 +1614,13 @@ megasas_queue_command(struct Scsi_Host *shost, struct scsi_cmnd *scmd) > > goto out_done; > > } > > > > - switch (scmd->cmnd[0]) { > > - case SYNCHRONIZE_CACHE: > > - /* > > - * FW takes care of flush cache on its own > > - * No need to send it down > > - */ > > + /* > > + * FW takes care of flush cache on its own for Virtual Disk. > > + * No need to send it down for VD. For JBOD send SYNCHRONIZE_CACHE to FW. > > + */ > > + if ((scmd->cmnd[0] == SYNCHRONIZE_CACHE) && MEGASAS_IS_LOGICAL(scmd)) { > > scmd->result = DID_OK << 16; > > goto out_done; > > - default: > > - break; > > } > > > > if (instance->instancet->build_and_issue_cmd(instance, scmd)) { > > > > MEGASAS_IS_LOGICAL is defined to be a macro with '?' operator, which has a lower precedence than '&&'. > > The macro should have been defined as: > > --- a/drivers/scsi/megaraid/megaraid_sas.h > > +++ b/drivers/scsi/megaraid/megaraid_sas.h > > @@ -1823,7 +1823,7 @@ struct megasas_instance_template { > > }; > > > > #define MEGASAS_IS_LOGICAL(scp) \ > > - (scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1 > > + ((scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1) > > > > #define MEGASAS_DEV_INDEX(inst, scp) \ > > ((scp->device->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL) + \ > > > > Dashi Cao > > I don't maintain 3.18-stable :) thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: version 3.18.44 to 3.18.45 introduced a bug in "drivers/scsi/megaraid/megaraid_sas_base.c" 2016-12-13 16:30 ` Greg Kroah-Hartman @ 2016-12-13 16:33 ` Randy Dunlap 2016-12-13 16:43 ` James Bottomley 0 siblings, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2016-12-13 16:33 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Dashi DS1 Cao, linux-kernel@vger.kernel.org, linux-scsi, stable, Sasha Levin On 12/13/16 08:30, Greg Kroah-Hartman wrote: > On Tue, Dec 13, 2016 at 08:08:27AM -0800, Randy Dunlap wrote: >> [adding other lists + gregkh] >> >> >> On 12/13/16 02:56, Dashi DS1 Cao wrote: >>> --- a/drivers/scsi/megaraid/megaraid_sas_base.c >>> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c >>> @@ -1614,16 +1614,13 @@ megasas_queue_command(struct Scsi_Host *shost, struct scsi_cmnd *scmd) >>> goto out_done; >>> } >>> >>> - switch (scmd->cmnd[0]) { >>> - case SYNCHRONIZE_CACHE: >>> - /* >>> - * FW takes care of flush cache on its own >>> - * No need to send it down >>> - */ >>> + /* >>> + * FW takes care of flush cache on its own for Virtual Disk. >>> + * No need to send it down for VD. For JBOD send SYNCHRONIZE_CACHE to FW. >>> + */ >>> + if ((scmd->cmnd[0] == SYNCHRONIZE_CACHE) && MEGASAS_IS_LOGICAL(scmd)) { >>> scmd->result = DID_OK << 16; >>> goto out_done; >>> - default: >>> - break; >>> } >>> >>> if (instance->instancet->build_and_issue_cmd(instance, scmd)) { >>> >>> MEGASAS_IS_LOGICAL is defined to be a macro with '?' operator, which has a lower precedence than '&&'. >>> The macro should have been defined as: >>> --- a/drivers/scsi/megaraid/megaraid_sas.h >>> +++ b/drivers/scsi/megaraid/megaraid_sas.h >>> @@ -1823,7 +1823,7 @@ struct megasas_instance_template { >>> }; >>> >>> #define MEGASAS_IS_LOGICAL(scp) \ >>> - (scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1 >>> + ((scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1) >>> >>> #define MEGASAS_DEV_INDEX(inst, scp) \ >>> ((scp->device->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL) + \ >>> >>> Dashi Cao >>> > > I don't maintain 3.18-stable :) > > thanks, > > greg k-h > Thanks. My bad. adding Sasha. -- ~Randy ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: version 3.18.44 to 3.18.45 introduced a bug in "drivers/scsi/megaraid/megaraid_sas_base.c" 2016-12-13 16:33 ` Randy Dunlap @ 2016-12-13 16:43 ` James Bottomley 2016-12-13 16:47 ` Greg Kroah-Hartman 0 siblings, 1 reply; 5+ messages in thread From: James Bottomley @ 2016-12-13 16:43 UTC (permalink / raw) To: Randy Dunlap, Greg Kroah-Hartman Cc: Dashi DS1 Cao, linux-kernel@vger.kernel.org, linux-scsi, stable, Sasha Levin On Tue, 2016-12-13 at 08:33 -0800, Randy Dunlap wrote: > On 12/13/16 08:30, Greg Kroah-Hartman wrote: > > I don't maintain 3.18-stable :) > > > > thanks, > > > > greg k-h > > > > Thanks. My bad. > > adding Sasha. This was all covered here: https://www.spinics.net/lists/stable/msg150608.html How did it get missed, and what should the process be? James ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: version 3.18.44 to 3.18.45 introduced a bug in "drivers/scsi/megaraid/megaraid_sas_base.c" 2016-12-13 16:43 ` James Bottomley @ 2016-12-13 16:47 ` Greg Kroah-Hartman 0 siblings, 0 replies; 5+ messages in thread From: Greg Kroah-Hartman @ 2016-12-13 16:47 UTC (permalink / raw) To: James Bottomley Cc: Randy Dunlap, Dashi DS1 Cao, linux-kernel@vger.kernel.org, linux-scsi, stable, Sasha Levin On Tue, Dec 13, 2016 at 08:43:41AM -0800, James Bottomley wrote: > On Tue, 2016-12-13 at 08:33 -0800, Randy Dunlap wrote: > > On 12/13/16 08:30, Greg Kroah-Hartman wrote: > > > I don't maintain 3.18-stable :) > > > > > > thanks, > > > > > > greg k-h > > > > > > > Thanks. My bad. > > > > adding Sasha. > > This was all covered here: > > https://www.spinics.net/lists/stable/msg150608.html > > How did it get missed, and what should the process be? I don't know how that got missed, did the "fixup" patch never make it into 3.18-stable? I know Sasha has been slow on that kernel, and it's about to go end-of-life, so perhaps he's just releasing them on a slower cycle at the moment... thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-13 16:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <23B7B563BA4E9446B962B142C86EF24ADB6F24@CNMAILEX03.lenovo.com>
2016-12-13 16:08 ` version 3.18.44 to 3.18.45 introduced a bug in "drivers/scsi/megaraid/megaraid_sas_base.c" Randy Dunlap
2016-12-13 16:30 ` Greg Kroah-Hartman
2016-12-13 16:33 ` Randy Dunlap
2016-12-13 16:43 ` James Bottomley
2016-12-13 16:47 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).