Re: patch 4.8 "net: handle no dst on skb in icmp6_send"

Re: patch 4.8 "net: handle no dst on skb in icmp6_send"

[Bronek Kozicki]

On 08/01/2017 22:50, David Miller wrote:
> From: Bronek Kozicki <brok@spamcop.net>
> Date: Sun, 8 Jan 2017 21:46:18 +0000
>
>> Hello,
>>
>> any particular reason why this fix
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=79dc7e3f1cd323be4c81aa1a94faa1b3ed987fb2
>> was missed from stable 4.8 line? Apparently the bug being fixed has
>> its own https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-9919
>>
>> Thank you for your hard work and best regards
>
> You should always check the networking -stable queue before asking
> such questions:
>
> 	http://patchwork.ozlabs.org/bundle/davem/stable/?submitter=&state=*&q=&archive=
>
> Every patch sitting there is queued up and will be submitted to -stable
> at some time in the next week or two, or whenever I get around to vetting
> and submitting -stable changes.
>
> The patch you are asking about it in fact in there, and will be attended
> to at an appropriate time.


Thank you David for prompt reply. I guess perhaps you are not aware that 
patches to stable line 4.8 might not be accepted after Sun Jan 8th 
(yesterday), and it will be considered EOL by version 4.8.17 ?

Best regards


B.

Re: patch 4.8 "net: handle no dst on skb in icmp6_send"

[Greg Kroah-Hartman]

On Mon, Jan 09, 2017 at 07:53:49AM +0000, Bronek Kozicki wrote:
> On 08/01/2017 22:50, David Miller wrote:
> > From: Bronek Kozicki <brok@spamcop.net>
> > Date: Sun, 8 Jan 2017 21:46:18 +0000
> > 
> > > Hello,
> > > 
> > > any particular reason why this fix
> > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=79dc7e3f1cd323be4c81aa1a94faa1b3ed987fb2
> > > was missed from stable 4.8 line? Apparently the bug being fixed has
> > > its own https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-9919
> > > 
> > > Thank you for your hard work and best regards
> > 
> > You should always check the networking -stable queue before asking
> > such questions:
> > 
> > 	http://patchwork.ozlabs.org/bundle/davem/stable/?submitter=&state=*&q=&archive=
> > 
> > Every patch sitting there is queued up and will be submitted to -stable
> > at some time in the next week or two, or whenever I get around to vetting
> > and submitting -stable changes.
> > 
> > The patch you are asking about it in fact in there, and will be attended
> > to at an appropriate time.
> 
> 
> Thank you David for prompt reply. I guess perhaps you are not aware that
> patches to stable line 4.8 might not be accepted after Sun Jan 8th
> (yesterday), and it will be considered EOL by version 4.8.17 ?

It's ok, no one should be using 4.8 anymore now, and if this is fixed in
4.9, all is good :)

thanks,

greg k-h

patch 4.8 "net: handle no dst on skb in icmp6_send"

[Bronek Kozicki]

Hello,

any particular reason why this fix 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=79dc7e3f1cd323be4c81aa1a94faa1b3ed987fb2 
was missed from stable 4.8 line? Apparently the bug being fixed has its 
own https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-9919

Thank you for your hard work and best regards


B.

Re: patch 4.8 "net: handle no dst on skb in icmp6_send"

[Greg Kroah-Hartman]

On Sun, Jan 08, 2017 at 02:28:13PM +0000, Bronek Kozicki wrote:
> Hello,
> 
> any particular reason why this fix https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=79dc7e3f1cd323be4c81aa1a94faa1b3ed987fb2
> was missed from stable 4.8 line? Apparently the bug being fixed has its own
> https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-9919
> 
> Thank you for your hard work and best regards

4.8 will be end-of-life on Monday (tomorrow), so I doubt this means
much, but please remember, for networking patches, the networking
maintainer is the one that sends them to me, so you need to ask this
type of thing on the netdev mailing list.

thanks,

greg k-h

Re: patch 4.8 "net: handle no dst on skb in icmp6_send"

[Jiri Slaby]

On 01/08/2017, 03:28 PM, Bronek Kozicki wrote:
> Hello,
> 
> any particular reason why this fix
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=79dc7e3f1cd323be4c81aa1a94faa1b3ed987fb2
> was missed from stable 4.8 line? Apparently the bug being fixed has its
> own https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-9919

The patch is marked as:
Fixes: 5d41ce29e ("net: icmp6_send should use dst dev to determine L3
domain")

and that is only in 4.9. So there seems to be a little point backporting
to older kernels.

thanks,
-- 
js
suse labs

Re: patch 4.8 "net: handle no dst on skb in icmp6_send"

[Bronek Kozicki]

On 11/01/2017 15:50, Jiri Slaby wrote:
> On 01/08/2017, 03:28 PM, Bronek Kozicki wrote:
>> Hello,
>>
>> any particular reason why this fix
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=79dc7e3f1cd323be4c81aa1a94faa1b3ed987fb2
>> was missed from stable 4.8 line? Apparently the bug being fixed has its
>> own https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-9919
>
> The patch is marked as:
> Fixes: 5d41ce29e ("net: icmp6_send should use dst dev to determine L3
> domain")
>
> and that is only in 4.9. So there seems to be a little point backporting
> to older kernels.


it is water under the bridge now, but I started this thread because I 
noticed that some distributions are adding this to their own 4.8 kernels


B.

Re: patch 4.8 "net: handle no dst on skb in icmp6_send"

[Jiri Slaby]

On 01/11/2017, 04:56 PM, Bronek Kozicki wrote:
> On 11/01/2017 15:50, Jiri Slaby wrote:
>> On 01/08/2017, 03:28 PM, Bronek Kozicki wrote:
>>> Hello,
>>>
>>> any particular reason why this fix
>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=79dc7e3f1cd323be4c81aa1a94faa1b3ed987fb2
>>>
>>> was missed from stable 4.8 line? Apparently the bug being fixed has its
>>> own https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-9919
>>
>> The patch is marked as:
>> Fixes: 5d41ce29e ("net: icmp6_send should use dst dev to determine L3
>> domain")
>>
>> and that is only in 4.9. So there seems to be a little point backporting
>> to older kernels.
> 
> 
> it is water under the bridge now, but I started this thread because I
> noticed that some distributions are adding this to their own 4.8 kernels

Which actually makes sense now, given 5d41ce29e *was* backported to 4.8.

-- 
js
suse labs