From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Stable@vger.kernel.org, jic23@kernel.org
Subject: Re: FAILED: patch "[PATCH] iio: 104-quad-8: Fix off-by-one errors when addressing IOR" failed to apply to 4.9-stable tree
Date: Mon, 9 Jan 2017 08:45:33 -0500 [thread overview]
Message-ID: <20170109134533.GC21888@sophia> (raw)
In-Reply-To: <148395045110272@kroah.com>
On Mon, Jan 09, 2017 at 09:27:31AM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.9-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
This patch fixes a commit in the current 4.10-rc tree; the relevant
commit is not present in the 4.9-stable tree.
I apologize for the confusion. In the future I'll try to be more
explicit whether fixes should be applied to the stable tree.
William Breathitt Gray
>
>------------------ original commit in Linus's tree ------------------
>
>>From 7e1c4058e741c781b262b15a2e86a40602aaa6b6 Mon Sep 17 00:00:00 2001
>From: William Breathitt Gray <vilhelm.gray@gmail.com>
>Date: Mon, 28 Nov 2016 16:55:34 -0500
>Subject: [PATCH] iio: 104-quad-8: Fix off-by-one errors when addressing IOR
>
>The Input/Output Control register (IOR) is offset by 1 from the
>respective channel data register. This patch fixes off-by-one errors
>when attempting to write to a channel IOR where the base address was not
>properly offset.
>
>Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
>Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>Cc: <Stable@vger.kernel.org>
>Signed-off-by: Jonathan Cameron <jic23@kernel.org>
>
>diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c
>index c0a69d7e9ce7..07b6d20c0756 100644
>--- a/drivers/iio/counter/104-quad-8.c
>+++ b/drivers/iio/counter/104-quad-8.c
>@@ -153,7 +153,7 @@ static int quad8_write_raw(struct iio_dev *indio_dev,
> ior_cfg = val | priv->preset_enable[chan->channel] << 1;
>
> /* Load I/O control configuration */
>- outb(0x40 | ior_cfg, base_offset);
>+ outb(0x40 | ior_cfg, base_offset + 1);
>
> return 0;
> case IIO_CHAN_INFO_SCALE:
>@@ -241,7 +241,7 @@ static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev,
> size_t len)
> {
> struct quad8_iio *const priv = iio_priv(indio_dev);
>- const int base_offset = priv->base + 2 * chan->channel;
>+ const int base_offset = priv->base + 2 * chan->channel + 1;
> bool preset_enable;
> int ret;
> unsigned int ior_cfg;
>
next prev parent reply other threads:[~2017-01-09 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 8:27 FAILED: patch "[PATCH] iio: 104-quad-8: Fix off-by-one errors when addressing IOR" failed to apply to 4.9-stable tree gregkh
2017-01-09 13:45 ` William Breathitt Gray [this message]
2017-01-09 17:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109134533.GC21888@sophia \
--to=vilhelm.gray@gmail.com \
--cc=Stable@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).