From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:33140 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939833AbdAINwB (ORCPT ); Mon, 9 Jan 2017 08:52:01 -0500 Date: Mon, 9 Jan 2017 14:51:59 +0100 From: Johan Hovold To: Russell Senior Cc: Johan Hovold , Aidan Thornton , Linux USB Mailing List , Grigori Goronzy , Karl Palsson , Eddi De Pieri , stable Subject: Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings Message-ID: <20170109135159.GP21536@localhost> References: <20161216173001.GG21690@localhost> <20161219105801.GJ21690@localhost> <20161220091312.GB26724@localhost> <20161220160748.GB8189@localhost> <20161220204900.GD8189@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161220204900.GD8189@localhost> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Dec 20, 2016 at 09:49:00PM +0100, Johan Hovold wrote: > On Tue, Dec 20, 2016 at 12:09:55PM -0800, Russell Senior wrote: > > On Tue, Dec 20, 2016 at 8:07 AM, Johan Hovold wrote: > > > > > Perhaps we should determine what else is working or broken first, > > > though. > > > > > > Russel, could you test if break-signalling works, and if the > > > modem-control signals (DTR/RTS) are asserted at open? Do you get any > > > interrupts when the modem-status changes (e.g. remote end hangs up -- > > > there should be debug messages)? > > > > Which version(s) would you like tested? > > You can use c51087107e88 ("USB: serial: ch341: rename modem-status > register"). As you noticed, I decided to revert to using direct register writes to avoid having the modem-control lines being toggled on open/set_termios. So with a trivial patch changing the initial LCR settings your device should now be supported. It would still be interesting to know whether the features mentioned above works. Testing that using the series I posted on Friday would be preferred (but not required). Thanks, Johan