From: Greg KH <gregkh@linuxfoundation.org>
To: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>
Cc: nab@linux-iscsi.org, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, Bart.VanAssche@sandisk.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
"Bryant G. Ly" <bgly@us.ibm.com>
Subject: Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code
Date: Mon, 9 Jan 2017 17:47:48 +0100 [thread overview]
Message-ID: <20170109164748.GA21437@kroah.com> (raw)
In-Reply-To: <1483978880-93705-1-git-send-email-bryantly@linux.vnet.ibm.com>
On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote:
> From: "Bryant G. Ly" <bgly@us.ibm.com>
>
> If srp_transfer_data fails within ibmvscsis_write_pending, then
> the most likely scenario is that the client timed out the op and
> removed the TCE mapping. Thus it will loop forever retrying the
> op that is pretty much guaranteed to fail forever. A better return
> code would be EIO instead of EAGAIN.
>
> Cc: stable@vger.kernel.org
> Reported-by: Steven Royer <seroyer@linux.vnet.ibm.com>
> Tested-by: Steven Royer <seroyer@linux.vnet.ibm.com>
> Signed-off-by: Bryant G. Ly <bgly@us.ibm.com>
> ---
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Why are you sending this to me?
confused,
greg k-h
next prev parent reply other threads:[~2017-01-09 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 16:21 [PATCH] ibmvscsis: Fix srp_transfer_data fail return code Bryant G. Ly
2017-01-09 16:47 ` Greg KH [this message]
2017-01-09 17:23 ` Bryant G. Ly
2017-01-09 17:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109164748.GA21437@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Bart.VanAssche@sandisk.com \
--cc=bgly@us.ibm.com \
--cc=bryantly@linux.vnet.ibm.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).