From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:49130 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbdAMMlq (ORCPT ); Fri, 13 Jan 2017 07:41:46 -0500 Date: Fri, 13 Jan 2017 13:41:47 +0100 From: Greg KH To: Johan Hovold Cc: linux-usb@vger.kernel.org, Dan Carpenter , stable Subject: Re: [PATCH] USB: serial: opticon: fix CTS retrieval at open Message-ID: <20170113124147.GA17858@kroah.com> References: <20170113122108.11235-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170113122108.11235-1-johan@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Jan 13, 2017 at 01:21:08PM +0100, Johan Hovold wrote: > The opticon driver used a control request at open to trigger a CTS > status notification to be sent over the bulk-in pipe. When the driver > was converted to using the generic read implementation, an inverted test > prevented this request from being sent, something which could lead to > TIOCMGET reporting an incorrect CTS state. > > Reported-by: Dan Carpenter > Fixes: 7a6ee2b02751 ("USB: opticon: switch to generic read > implementation") > Cc: stable > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/opticon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Greg Kroah-Hartman