From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:51264 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751226AbdARHrl (ORCPT
        <rfc822;stable@vger.kernel.org>); Wed, 18 Jan 2017 02:47:41 -0500
Date: Wed, 18 Jan 2017 08:47:52 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Niklas =?iso-8859-1?Q?S=F6derlund?=
        <niklas.soderlund@ragnatech.se>
Cc: Guenter Roeck <linux@roeck-us.net>, stable <stable@vger.kernel.org>
Subject: Re: Build failures in v4.9-stable-queue
 (drivers/pinctrl/sh-pfc/pfc-r8a7795.c)
Message-ID: <20170118074752.GA22213@kroah.com>
References: <ba3e591b-82a1-06ed-4e55-632aae79de14@roeck-us.net>
 <20170118070348.GA11886@kroah.com>
 <20170118073605.GA15854@bigcity.dyn.berto.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170118073605.GA15854@bigcity.dyn.berto.se>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wed, Jan 18, 2017 at 08:36:05AM +0100, Niklas Söderlund wrote:
> Hi Guenter and Greg,
> 
> On 2017-01-18 08:03:48 +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 17, 2017 at 09:22:38PM -0800, Guenter Roeck wrote:
> > > drivers/pinctrl/sh-pfc/pfc-r8a7795.c:5191:38: error: array type has incomplete element type ‘struct sh_pfc_bias_info’
> > >  static const struct sh_pfc_bias_info bias_info[] = {
> > >                                       ^
> > > drivers/pinctrl/sh-pfc/pfc-r8a7795.c: In function ‘r8a7795_pinmux_get_bias’:
> > > drivers/pinctrl/sh-pfc/pfc-r8a7795.c:5362:9: error: implicit declaration of function ‘sh_pfc_pin_to_bias_info’ [-Werror=implicit-function-declaration]
> > >   info = sh_pfc_pin_to_bias_info(bias_info, ARRAY_SIZE(bias_info), pin);
> > > 
> > > This affects arm64 builds (defconfig, allmodconfig).
> > > 
> > > Guess something is missing in commit 30c49bf7c504 ("pinctrl: sh-pfc: r8a7795:
> > > Use lookup function for bias data"). Copying the author.
> > 
> > Looks like I need to add c314c9f15aa5 ("pinctrl: sh-pfc: Add helper to
> > handle bias lookup table") to handle this.
> 
> Yes this commit is also needed.
> 
> I see my error that I marked the first commit with a Fixes tag while the 
> dependency was not documented. In the future how can I document such 
> dependencies?

You can add the commit id after the cc: stable line like:
	cc: stable <stable@vger.kernel.org> # 4.4+  c314c9f15aa5

the Documentation/stable_kernel_rules.txt file (wherever it moved to),
should describe this...

thanks,

greg k-h