From: Greg KH <gregkh@linuxfoundation.org>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: Sage Weil <sage@redhat.com>,
spender@grsecurity.net, stable@vger.kernel.org,
stable-commits@vger.kernel.org
Subject: Re: Patch "libceph: introduce ceph_crypt() for in-place en/decryption" has been added to the 4.9-stable tree
Date: Fri, 20 Jan 2017 16:34:52 +0100 [thread overview]
Message-ID: <20170120153452.GA5591@kroah.com> (raw)
In-Reply-To: <CAOi1vP8VOfmLQPnGipqAnp8vyyGt62ZPyuiJWTyCGgpM_-x+Qw@mail.gmail.com>
On Fri, Jan 20, 2017 at 04:26:16PM +0100, Ilya Dryomov wrote:
> On Fri, Jan 20, 2017 at 4:08 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > Ok, what were the surrounding commits? Don't we need this to handle the
> > vmalloced stack issue in 4.9? If not, that's fine, I'll drop this,
> > otherwise it would be good to fix that up, right?
>
> Yes, but it's pretty large in terms of diffstat. Honestly, I'm not
> worried -- our on-stack buffers are really small and the chances that
> any of them will straddle a page should be tiny.
>
> Here is the list (bottom to top):
>
> 2b1e1a7cd0a6 libceph: remove now unused ceph_*{en,de}crypt*() functions
> e15fd0a11db0 libceph: switch ceph_x_decrypt() to ceph_crypt()
> d03857c63bb0 libceph: switch ceph_x_encrypt() to ceph_crypt()
> 4eb4517ce7c9 libceph: tweak calcu_signature() a little
> 7882a26d2e2e libceph: rename and align ceph_x_authorizer::reply_buf
> a45f795c65b4 libceph: introduce ceph_crypt() for in-place en/decryption
> 55d9cc834f93 libceph: introduce ceph_x_encrypt_offset()
> 462e650451c5 libceph: old_key in process_one_ticket() is redundant
> 36721ece1e84 libceph: ceph_x_encrypt_buflen() takes in_len
>
> Can probably drop one or two, but you want to take these, I'd rather
> you take them all.
Given the length that 4.9 is going to be around, I'd prefer to have this
work correctly. I'll drop this single patch now, but will queue this
larger list up later when I get a chance to do more testing and review.
Brad, thanks again for pointing this issue out, much appreciated for the
heads up, I had missed this one in my review.
thanks,
greg k-h
next prev parent reply other threads:[~2017-01-20 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 14:53 Patch "libceph: introduce ceph_crypt() for in-place en/decryption" has been added to the 4.9-stable tree gregkh
2017-01-20 15:05 ` Ilya Dryomov
2017-01-20 15:08 ` Greg KH
2017-01-20 15:12 ` Greg KH
2017-01-20 15:26 ` Ilya Dryomov
2017-01-20 15:34 ` Greg KH [this message]
2017-01-20 15:57 ` Ilya Dryomov
2017-01-20 17:38 ` Greg KH
2017-01-23 15:41 ` Greg KH
2017-01-23 15:47 ` Ilya Dryomov
2017-01-23 16:05 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2017-01-23 15:35 gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120153452.GA5591@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=idryomov@gmail.com \
--cc=sage@redhat.com \
--cc=spender@grsecurity.net \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).