From: Greg KH <gregkh@linuxfoundation.org>
To: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci: Ignore unexpected CARD_INT interrupts
Date: Thu, 26 Jan 2017 10:26:45 +0100 [thread overview]
Message-ID: <20170126092645.GA32645@kroah.com> (raw)
In-Reply-To: <20170126012335.28878-1-krisman@collabora.co.uk>
On Wed, Jan 25, 2017 at 11:23:35PM -0200, Gabriel Krisman Bertazi wrote:
> Hi Greg,
>
> The following patch prevents an illegal command from getting sent to SD
> cards, which in turn avoids a lock-up during boot. Can you please apply
> to the 4.9 and 4.4 stable trees?
>
> The patch was generated against the 4.9 and there will be a trivial
> context conflict when applying to the 4.4.y branch. If you prefer, I
> can resend another version against that branch.
>
> Thanks!
>
> -- >8 --
>
> commit 5b19196de18e1522630326c80a40a64181c78a1c upstream.
I don't see this commit in Linus's tree, are you sure you got it
correct?
> One of our kernelCI boxes hanged at boot because a faulty eSDHC device
> was triggering spurious CARD_INT interrupts for SD cards, causing CMD52
> reads, which are not allowed for SD devices. This adds a sanity check
> to the interruption path, preventing that illegal command from getting
> sent if the CARD_INT interruption should be disabled.
>
> This quirk allows that particular machine to resume boot despite the
> faulty hardware, instead of getting hung dealing with thousands of
> mishandled interrupts.
>
> Suggested-by: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> (cherry picked from commit 5b19196de18e1522630326c80a40a64181c78a1c)
> ---
> drivers/mmc/host/sdhci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Are you sure this is in Linus's tree? I can't find it anywhere.
You did read Documentation/stable_kernel_rules.txt, right?
thanks,
greg k-h
next prev parent reply other threads:[~2017-01-26 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 1:23 [PATCH] mmc: sdhci: Ignore unexpected CARD_INT interrupts Gabriel Krisman Bertazi
2017-01-26 9:26 ` Greg KH [this message]
2017-01-27 17:01 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126092645.GA32645@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=krisman@collabora.co.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).