From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:60590 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbdBDQ0T (ORCPT ); Sat, 4 Feb 2017 11:26:19 -0500 Date: Sat, 4 Feb 2017 17:26:17 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, stable Subject: Re: [PATCH] KVM: x86: do not save guest-unsupported XSAVE state Message-ID: <20170204162616.GB5582@potion> References: <20170201131953.30098-1-rkrcmar@redhat.com> <42ae50e8-444c-5b0b-e13b-266e3bf80ca3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <42ae50e8-444c-5b0b-e13b-266e3bf80ca3@redhat.com> Sender: stable-owner@vger.kernel.org List-ID: 2017-02-01 16:13-0800, Paolo Bonzini: > On 01/02/2017 05:19, Radim Krčmář wrote: >> Saving unsupported state prevents migration when the new host does not >> support a XSAVE feature of the original host, even if the feature is not >> exposed to the guest. >> >> We've masked host features with guest-visible features before, with >> 4344ee981e21 ("KVM: x86: only copy XSAVE state for the supported >> features") and dropped it when implementing XSAVES. Do it again. >> >> Fixes: df1daba7d1cb ("KVM: x86: support XSAVES usage in the host") >> Signed-off-by: Radim Krčmář > > Cc: stable@vger.kernel.org > Reviewed-by: Paolo Bonzini > > Please apply to kvm/master and send it yourself to Linus since I don't > have access to my machine this week. Done, thanks.