From: Greg KH <greg@kroah.com>
To: Dawei Chien <dawei.chien@mediatek.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups
Date: Tue, 21 Feb 2017 13:50:58 +0100 [thread overview]
Message-ID: <20170221125058.GA15472@kroah.com> (raw)
In-Reply-To: <1487679418-61825-1-git-send-email-dawei.chien@mediatek.com>
On Tue, Feb 21, 2017 at 08:16:58PM +0800, Dawei Chien wrote:
> If thermal bank with 4 sensors, thermal driver should read TEMP_MSR3.
>
> However, currently thermal driver would not read TEMP_MSR3 since mt8173
> thermal driver only use 3 sensors on each thermal bank at the same time,
> so this patch would not effect temperature.
> Only if mt mt8173 thermal driver use 4 sensors on any thermal bank, would
> read third sensor two times, and lose fourth sensor of vale.
>
> cc: stable@vger.kernel.org
> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
> Change-Id: Ief4f4986d637cf69c2b15cc013d1b93d77c6b615
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
> ---
> drivers/thermal/mtk_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 34169c3..c124151 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -191,7 +191,7 @@ struct mtk_thermal {
> };
>
> const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = {
> - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2
> + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3
> };
>
> const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = {
> --
> 1.9.1
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2017-02-21 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BBB>
2017-02-21 12:16 ` [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Dawei Chien
2017-02-21 12:50 ` Greg KH [this message]
2017-02-21 12:19 Dawei Chien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221125058.GA15472@kroah.com \
--to=greg@kroah.com \
--cc=dawei.chien@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).