* [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups
[not found] <BBB>
@ 2017-02-21 12:16 ` Dawei Chien
2017-02-21 12:50 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Dawei Chien @ 2017-02-21 12:16 UTC (permalink / raw)
To: Dawei Chien; +Cc: stable
If thermal bank with 4 sensors, thermal driver should read TEMP_MSR3.
However, currently thermal driver would not read TEMP_MSR3 since mt8173
thermal driver only use 3 sensors on each thermal bank at the same time,
so this patch would not effect temperature.
Only if mt mt8173 thermal driver use 4 sensors on any thermal bank, would
read third sensor two times, and lose fourth sensor of vale.
cc: stable@vger.kernel.org
Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
Change-Id: Ief4f4986d637cf69c2b15cc013d1b93d77c6b615
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
---
drivers/thermal/mtk_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 34169c3..c124151 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -191,7 +191,7 @@ struct mtk_thermal {
};
const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = {
- TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2
+ TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3
};
const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups
@ 2017-02-21 12:19 Dawei Chien
0 siblings, 0 replies; 3+ messages in thread
From: Dawei Chien @ 2017-02-21 12:19 UTC (permalink / raw)
To: Chien Dawei; +Cc: stable
If thermal bank with 4 sensors, thermal driver should read TEMP_MSR3.
However, currently thermal driver would not read TEMP_MSR3 since mt8173
thermal driver only use 3 sensors on each thermal bank at the same time,
so this patch would not effect temperature.
Only if mt mt8173 thermal driver use 4 sensors on any thermal bank, would
read third sensor two times, and lose fourth sensor of vale.
cc: stable@vger.kernel.org
Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
Change-Id: Ief4f4986d637cf69c2b15cc013d1b93d77c6b615
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
---
drivers/thermal/mtk_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 34169c3..c124151 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -191,7 +191,7 @@ struct mtk_thermal {
};
const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = {
- TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2
+ TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3
};
const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups
2017-02-21 12:16 ` [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Dawei Chien
@ 2017-02-21 12:50 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2017-02-21 12:50 UTC (permalink / raw)
To: Dawei Chien; +Cc: stable
On Tue, Feb 21, 2017 at 08:16:58PM +0800, Dawei Chien wrote:
> If thermal bank with 4 sensors, thermal driver should read TEMP_MSR3.
>
> However, currently thermal driver would not read TEMP_MSR3 since mt8173
> thermal driver only use 3 sensors on each thermal bank at the same time,
> so this patch would not effect temperature.
> Only if mt mt8173 thermal driver use 4 sensors on any thermal bank, would
> read third sensor two times, and lose fourth sensor of vale.
>
> cc: stable@vger.kernel.org
> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
> Change-Id: Ief4f4986d637cf69c2b15cc013d1b93d77c6b615
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
> ---
> drivers/thermal/mtk_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 34169c3..c124151 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -191,7 +191,7 @@ struct mtk_thermal {
> };
>
> const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = {
> - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2
> + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3
> };
>
> const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = {
> --
> 1.9.1
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-21 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <BBB>
2017-02-21 12:16 ` [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Dawei Chien
2017-02-21 12:50 ` Greg KH
2017-02-21 12:19 Dawei Chien
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).