From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:59188 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbdBUMvX (ORCPT ); Tue, 21 Feb 2017 07:51:23 -0500 Date: Tue, 21 Feb 2017 13:50:58 +0100 From: Greg KH To: Dawei Chien Cc: stable@vger.kernel.org Subject: Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Message-ID: <20170221125058.GA15472@kroah.com> References: <1487679418-61825-1-git-send-email-dawei.chien@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487679418-61825-1-git-send-email-dawei.chien@mediatek.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Feb 21, 2017 at 08:16:58PM +0800, Dawei Chien wrote: > If thermal bank with 4 sensors, thermal driver should read TEMP_MSR3. > > However, currently thermal driver would not read TEMP_MSR3 since mt8173 > thermal driver only use 3 sensors on each thermal bank at the same time, > so this patch would not effect temperature. > Only if mt mt8173 thermal driver use 4 sensors on any thermal bank, would > read third sensor two times, and lose fourth sensor of vale. > > cc: stable@vger.kernel.org > Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") > Change-Id: Ief4f4986d637cf69c2b15cc013d1b93d77c6b615 > Reviewed-by: Matthias Brugger > Signed-off-by: Dawei Chien > --- > drivers/thermal/mtk_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > index 34169c3..c124151 100644 > --- a/drivers/thermal/mtk_thermal.c > +++ b/drivers/thermal/mtk_thermal.c > @@ -191,7 +191,7 @@ struct mtk_thermal { > }; > > const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = { > - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2 > + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3 > }; > > const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = { > -- > 1.9.1 This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly.