From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:48870 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbdCHQIE (ORCPT ); Wed, 8 Mar 2017 11:08:04 -0500 Date: Wed, 8 Mar 2017 16:55:23 +0100 From: Greg KH To: Jens Axboe Cc: osandov@fb.com, tj@kernel.org, tom.leiming@gmail.com, stable@vger.kernel.org, stable-commits@vger.kernel.org Subject: Re: Patch "loop: fix LO_FLAGS_PARTSCAN hang" has been added to the 4.10-stable tree Message-ID: <20170308155523.GA28388@kroah.com> References: <1488987540546@kroah.com> <39818fd9-a870-cc63-6ba0-0b9f197354eb@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39818fd9-a870-cc63-6ba0-0b9f197354eb@fb.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Mar 08, 2017 at 08:47:39AM -0700, Jens Axboe wrote: > On 03/08/2017 08:39 AM, gregkh@linuxfoundation.org wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > loop: fix LO_FLAGS_PARTSCAN hang > > > > to the 4.10-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > loop-fix-lo_flags_partscan-hang.patch > > and it can be found in the queue-4.10 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let know about it. > > > > > > From e02898b423802b1f3a3aaa7f16e896da069ba8f7 Mon Sep 17 00:00:00 2001 > > From: Omar Sandoval > > Date: Wed, 1 Mar 2017 10:42:38 -0800 > > Subject: loop: fix LO_FLAGS_PARTSCAN hang > > > > From: Omar Sandoval > > > > commit e02898b423802b1f3a3aaa7f16e896da069ba8f7 upstream. > > > > loop_reread_partitions() needs to do I/O, but we just froze the queue, > > so we end up waiting forever. This can easily be reproduced with losetup > > -P. Fix it by moving the reread to after we unfreeze the queue. > > > > Fixes: ecdd09597a57 ("block/loop: fix race between I/O and set_status") > > Reported-by: Tejun Heo > > Signed-off-by: Omar Sandoval > > Reviewed-by: Ming Lei > > Signed-off-by: Jens Axboe > > Signed-off-by: Greg Kroah-Hartman > > Why is this being added to a bunch of trees that don't have the commit > that it fixes? It should not go into any of these. Because the commit this fixes just got added to all of those trees. Is that not the correct thing needed here? thanks, greg k-h