From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost.localdomain ([127.0.0.1]:43796 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23993875AbdCTKDzuREfR (ORCPT + 1 other); Mon, 20 Mar 2017 11:03:55 +0100 Date: Mon, 20 Mar 2017 11:03:53 +0100 From: Ralf Baechle To: Ben Hutchings Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Arnd Bergmann , linux-mips@linux-mips.org Subject: Re: [PATCH 4.4 04/35] MIPS: Update defconfigs for NF_CT_PROTO_DCCP/UDPLITE change Message-ID: <20170320100353.GC14919@linux-mips.org> References: <20170316142906.685052998@linuxfoundation.org> <20170316142906.994447562@linuxfoundation.org> <1489939516.2852.71.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1489939516.2852.71.camel@decadent.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Sun, Mar 19, 2017 at 04:05:16PM +0000, Ben Hutchings wrote: > Date: Sun, 19 Mar 2017 16:05:16 +0000 > From: Ben Hutchings > To: Greg Kroah-Hartman , > linux-kernel@vger.kernel.org > Cc: stable@vger.kernel.org, Arnd Bergmann , > linux-mips@linux-mips.org, Ralf Baechle > Subject: Re: [PATCH 4.4 04/35] MIPS: Update defconfigs for > NF_CT_PROTO_DCCP/UDPLITE change > Content-Type: multipart/signed; micalg="pgp-sha512"; > protocol="application/pgp-signature"; > boundary="=-AwAI9QrjXVRk/IPasf40" > > On Thu, 2017-03-16 at 23:29 +0900, Greg Kroah-Hartman wrote: > > 4.4-stable review patch.��If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Arnd Bergmann > > > > commit 9ddc16ad8e0bc7742fc96d5aaabc5b8698512cd1 upstream. > > > > In linux-4.10-rc, NF_CT_PROTO_UDPLITE and NF_CT_PROTO_DCCP are bool > > symbols instead of tristate, and kernelci.org reports a bunch of > > warnings for this, like: > > > > arch/mips/configs/malta_kvm_guest_defconfig:63:warning: symbol value 'm' invalid for NF_CT_PROTO_UDPLITE > > arch/mips/configs/malta_defconfig:62:warning: symbol value 'm' invalid for NF_CT_PROTO_DCCP > > arch/mips/configs/malta_defconfig:63:warning: symbol value 'm' invalid for NF_CT_PROTO_UDPLITE > > arch/mips/configs/ip22_defconfig:70:warning: symbol value 'm' invalid for NF_CT_PROTO_DCCP > > arch/mips/configs/ip22_defconfig:71:warning: symbol value 'm' invalid for NF_CT_PROTO_UDPLITE > > > > This changes all the MIPS defconfigs with these symbols to have them > > built-in. > > > > Fixes: 9b91c96c5d1f ("netfilter: conntrack: built-in support for UDPlite") > > Fixes: c51d39010a1b ("netfilter: conntrack: built-in support for DCCP") > [...] > > I don't think this was needed for 4.4 or 4.9, as those symbols were > still tristate type. Indeed, there's no waring for "make ARCH=mips malta_kvm_guest_defconfig". Ralf