From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:48178 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933945AbdCVJGc (ORCPT ); Wed, 22 Mar 2017 05:06:32 -0400 Date: Wed, 22 Mar 2017 10:05:42 +0100 From: Stanislaw Gruszka To: Ankur Arora Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: Re: [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen Message-ID: <20170322090541.GA2860@redhat.com> References: <1490136218-3857-1-git-send-email-ankur.a.arora@oracle.com> <1490136218-3857-3-git-send-email-ankur.a.arora@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490136218-3857-3-git-send-email-ankur.a.arora@oracle.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Mar 21, 2017 at 03:43:38PM -0700, Ankur Arora wrote: > This was broken in commit cd979883b9ede90643e019f33cb317933eb867b4. > do_suspend (from xen/manage.c) and thus xen_resume_notifier never get > called on the initial-domain at resume (it is if running as guest.) > > The rationale for the breaking change was that upload_pm_data() > potentially does blocking work in syscore_resume(). This patch > addresses the original issue by scheduling upload_pm_data() to > execute in workqueue context. It is ok to do upload_pm_data() with delay i.e. after some other resume actions are done and possibly xen-acpi-processor is in running state ? Stanislaw