From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: "Dmitry Vyukov" <dvyukov@google.com>,
"David Hildenbrand" <david@redhat.com>,
"KVM list" <kvm@vger.kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
stable <stable@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail
Date: Fri, 24 Mar 2017 15:40:51 +0100 [thread overview]
Message-ID: <20170324154051.5398a703.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20170324103257.GA5250@amt.cnet>
On Fri, 24 Mar 2017 07:33:01 -0300
Marcelo Tosatti <mtosatti@redhat.com> wrote:
> Still dislike the "unregister all bus devices" as that renders the guest
> unuseable. Can't you fail gracefully? Say force qemu error.
The callers are probably too varied to find a common way to do that
(multiply with different user space tools).
At least for some cases, the guest will be terminated in the near
future anyway: For example, on s390 a NULL bus will cause an error to
be propagated through KVM_RUN on the next guest->host virtio
notification, which will cause qemu to terminate the guest.
This situation is not ideal, but this is probably the most reasonable
approach.
prev parent reply other threads:[~2017-03-24 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 17:24 [PATCH v2] KVM: kvm_io_bus_unregister_dev() should never fail David Hildenbrand
2017-03-23 17:31 ` Cornelia Huck
2017-03-23 20:42 ` Marcelo Tosatti
2017-03-24 8:48 ` Dmitry Vyukov
2017-03-24 8:55 ` David Hildenbrand
2017-03-24 9:33 ` Cornelia Huck
2017-03-24 10:33 ` Marcelo Tosatti
2017-03-24 14:40 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324154051.5398a703.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=david@redhat.com \
--cc=dvyukov@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox