From: Gustavo Padovan <gustavo@padovan.org>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: dri-devel@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm/vmwgfx: Remove getparam error message
Date: Tue, 28 Mar 2017 10:15:07 -0300 [thread overview]
Message-ID: <20170328131507.GC2311@joana> (raw)
In-Reply-To: <1490690686-4235-1-git-send-email-thellstrom@vmware.com>
Hi Thomas,
2017-03-28 Thomas Hellstrom <thellstrom@vmware.com>:
> The mesa winsys sometimes uses unimplemented parameter requests to
> check for features. Remove the error message to avoid bloating the
> kernel log.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
> Reviewed-by: Brian Paul <brianp@vmware.com>
> Reviewed-by: Sinclair Yeh <syeh@vmware.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> index 1802d0e..5ec24fd 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> @@ -114,8 +114,6 @@ int vmw_getparam_ioctl(struct drm_device *dev, void *data,
> param->value = dev_priv->has_dx;
> break;
> default:
> - DRM_ERROR("Illegal vmwgfx get param request: %d\n",
> - param->param);
How about turning it into a debug message instead? Do you think it will
be useful?
Gustavo
prev parent reply other threads:[~2017-03-28 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 8:44 [PATCH] drm/vmwgfx: Remove getparam error message Thomas Hellstrom
2017-03-28 13:15 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328131507.GC2311@joana \
--to=gustavo@padovan.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).