From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f193.google.com ([209.85.216.193]:33026 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754047AbdC1NPZ (ORCPT ); Tue, 28 Mar 2017 09:15:25 -0400 Received: by mail-qt0-f193.google.com with SMTP id r45so11975373qte.0 for ; Tue, 28 Mar 2017 06:15:19 -0700 (PDT) Date: Tue, 28 Mar 2017 10:15:07 -0300 From: Gustavo Padovan To: Thomas Hellstrom Cc: dri-devel@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/vmwgfx: Remove getparam error message Message-ID: <20170328131507.GC2311@joana> References: <1490690686-4235-1-git-send-email-thellstrom@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490690686-4235-1-git-send-email-thellstrom@vmware.com> Sender: stable-owner@vger.kernel.org List-ID: Hi Thomas, 2017-03-28 Thomas Hellstrom : > The mesa winsys sometimes uses unimplemented parameter requests to > check for features. Remove the error message to avoid bloating the > kernel log. > > Cc: > Signed-off-by: Thomas Hellstrom > Reviewed-by: Brian Paul > Reviewed-by: Sinclair Yeh > --- > drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c > index 1802d0e..5ec24fd 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c > @@ -114,8 +114,6 @@ int vmw_getparam_ioctl(struct drm_device *dev, void *data, > param->value = dev_priv->has_dx; > break; > default: > - DRM_ERROR("Illegal vmwgfx get param request: %d\n", > - param->param); How about turning it into a debug message instead? Do you think it will be useful? Gustavo