From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
Timur Tabi <timur@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 4.4 05/14] pinctrl: qcom: Dont clear status bit on irq_unmask
Date: Thu, 30 Mar 2017 11:58:39 +0200 [thread overview]
Message-ID: <20170330094945.851218364@linuxfoundation.org> (raw)
In-Reply-To: <20170330094944.906915050@linuxfoundation.org>
4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bjorn Andersson <bjorn.andersson@linaro.org>
commit a6566710adaa4a7dd5e0d99820ff9c9c30ee5951 upstream.
Clearing the status bit on irq_unmask will discard any pending interrupt
that did arrive after the irq_ack, i.e. while the IRQ handler function
was executing.
Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver")
Cc: Stephen Boyd <sboyd@codeaurora.org>
Reported-by: Timur Tabi <timur@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 4 ----
1 file changed, 4 deletions(-)
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -597,10 +597,6 @@ static void msm_gpio_irq_unmask(struct i
spin_lock_irqsave(&pctrl->lock, flags);
- val = readl(pctrl->regs + g->intr_status_reg);
- val &= ~BIT(g->intr_status_bit);
- writel(val, pctrl->regs + g->intr_status_reg);
-
val = readl(pctrl->regs + g->intr_cfg_reg);
val |= BIT(g->intr_enable_bit);
writel(val, pctrl->regs + g->intr_cfg_reg);
next prev parent reply other threads:[~2017-03-30 9:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 9:58 [PATCH 4.4 00/14] 4.4.59-stable review Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 01/14] xfrm: policy: init locks early Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 02/14] xfrm_user: validate XFRM_MSG_NEWAE XFRMA_REPLAY_ESN_VAL replay_window Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 03/14] xfrm_user: validate XFRM_MSG_NEWAE incoming ESN size harder Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 04/14] virtio_balloon: init 1st buffer in stats vq Greg Kroah-Hartman
2017-03-30 9:58 ` Greg Kroah-Hartman [this message]
2017-03-30 9:58 ` [PATCH 4.4 06/14] c6x/ptrace: Remove useless PTRACE_SETREGSET implementation Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 07/14] h8300/ptrace: Fix incorrect register transfer count Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 08/14] mips/ptrace: Preserve previous registers for short regset write Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 09/14] sparc/ptrace: " Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 10/14] metag/ptrace: " Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 11/14] metag/ptrace: Provide default TXSTATUS for short NT_PRSTATUS Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 12/14] metag/ptrace: Reject partial NT_METAG_RPIPE writes Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 13/14] fscrypt: remove broken support for detecting keyring key revocation Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 14/14] sched/rt: Add a missing rescheduling point Greg Kroah-Hartman
2017-03-30 18:52 ` [PATCH 4.4 00/14] 4.4.59-stable review Shuah Khan
2017-03-31 3:45 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330094945.851218364@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).