Re: Patch "mmc: sdhci: Disable runtime pm when the sdio_irq is enabled" has been added to the 4.4-stable tree

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Apr 03, 2017 at 02:41:37PM +0200, gregkh@linuxfoundation.org wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     mmc: sdhci: Disable runtime pm when the sdio_irq is enabled
> 
> to the 4.4-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      mmc-sdhci-disable-runtime-pm-when-the-sdio_irq-is-enabled.patch
> and it can be found in the queue-4.4 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 

Sorry, this broke the build, now removed.

greg k-h


> 
> >From 923713b357455cfb9aca2cd3429cb0806a724ed2 Mon Sep 17 00:00:00 2001
> From: Hans de Goede <hdegoede@redhat.com>
> Date: Sun, 26 Mar 2017 13:14:45 +0200
> Subject: mmc: sdhci: Disable runtime pm when the sdio_irq is enabled
> 
> From: Hans de Goede <hdegoede@redhat.com>
> 
> commit 923713b357455cfb9aca2cd3429cb0806a724ed2 upstream.
> 
> SDIO cards may need clock to send the card interrupt to the host.
> 
> On a cherrytrail tablet with a RTL8723BS wifi chip, without this patch
> pinging the tablet results in:
> 
> PING 192.168.1.14 (192.168.1.14) 56(84) bytes of data.
> 64 bytes from 192.168.1.14: icmp_seq=1 ttl=64 time=78.6 ms
> 64 bytes from 192.168.1.14: icmp_seq=2 ttl=64 time=1760 ms
> 64 bytes from 192.168.1.14: icmp_seq=3 ttl=64 time=753 ms
> 64 bytes from 192.168.1.14: icmp_seq=4 ttl=64 time=3.88 ms
> 64 bytes from 192.168.1.14: icmp_seq=5 ttl=64 time=795 ms
> 64 bytes from 192.168.1.14: icmp_seq=6 ttl=64 time=1841 ms
> 64 bytes from 192.168.1.14: icmp_seq=7 ttl=64 time=810 ms
> 64 bytes from 192.168.1.14: icmp_seq=8 ttl=64 time=1860 ms
> 64 bytes from 192.168.1.14: icmp_seq=9 ttl=64 time=812 ms
> 64 bytes from 192.168.1.14: icmp_seq=10 ttl=64 time=48.6 ms
> 
> Where as with this patch I get:
> 
> PING 192.168.1.14 (192.168.1.14) 56(84) bytes of data.
> 64 bytes from 192.168.1.14: icmp_seq=1 ttl=64 time=3.96 ms
> 64 bytes from 192.168.1.14: icmp_seq=2 ttl=64 time=1.97 ms
> 64 bytes from 192.168.1.14: icmp_seq=3 ttl=64 time=17.2 ms
> 64 bytes from 192.168.1.14: icmp_seq=4 ttl=64 time=2.46 ms
> 64 bytes from 192.168.1.14: icmp_seq=5 ttl=64 time=2.83 ms
> 64 bytes from 192.168.1.14: icmp_seq=6 ttl=64 time=1.40 ms
> 64 bytes from 192.168.1.14: icmp_seq=7 ttl=64 time=2.10 ms
> 64 bytes from 192.168.1.14: icmp_seq=8 ttl=64 time=1.40 ms
> 64 bytes from 192.168.1.14: icmp_seq=9 ttl=64 time=2.04 ms
> 64 bytes from 192.168.1.14: icmp_seq=10 ttl=64 time=1.40 ms
> 
> Cc: Dong Aisheng <b29396@freescale.com>
> Cc: Ian W MORRISON <ianwmorrison@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> ---
>  drivers/mmc/host/sdhci.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1886,6 +1886,9 @@ static int sdhci_prepare_hs400_tuning(st
>  	struct sdhci_host *host = mmc_priv(mmc);
>  	unsigned long flags;
>  
> +	if (enable)
> +		pm_runtime_get_noresume(host->mmc->parent);
> +
>  	spin_lock_irqsave(&host->lock, flags);
>  	host->flags |= SDHCI_HS400_TUNING;
>  	spin_unlock_irqrestore(&host->lock, flags);
> @@ -2236,6 +2239,9 @@ static void sdhci_card_event(struct mmc_
>  	}
>  
>  	spin_unlock_irqrestore(&host->lock, flags);
> +
> +	if (!enable)
> +		pm_runtime_put_noidle(host->mmc->parent);
>  }
>  
>  static const struct mmc_host_ops sdhci_ops = {
> 
> 
> Patches currently in stable-queue which might be from hdegoede@redhat.com are
> 
> queue-4.4/mmc-sdhci-disable-runtime-pm-when-the-sdio_irq-is-enabled.patch