From: Greg KH <gregkh@linuxfoundation.org>
To: Doug Anderson <dianders@chromium.org>
Cc: arve@android.com, riandrews@android.com,
Todd Kjos <tkjos@google.com>,
devel@driverdev.osuosl.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [RFC PATCH] binder: Don't require the binder lock when killed in binder_thread_read()
Date: Mon, 3 Apr 2017 15:25:02 +0200 [thread overview]
Message-ID: <20170403132502.GA32491@kroah.com> (raw)
In-Reply-To: <CAD=FV=X-EPfBLE3oQH1p1OwKrHNPzw+R10nk8poJD-GL=itzSQ@mail.gmail.com>
On Sat, Apr 01, 2017 at 07:34:53PM -0700, Doug Anderson wrote:
> Hi,
>
> On Fri, Mar 31, 2017 at 11:48 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Mar 31, 2017 at 02:00:13PM -0700, Doug Anderson wrote:
> >> On Fri, Mar 31, 2017 at 12:29 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >> BTW: I presume that nobody has decided that it would be a wise idea to
> >> pick the OOM reaper code back to any stable trees? It seemed a bit
> >> too scary to me, so I wrote a dumber (but easier to backport) solution
> >> that avoided the deadlocks I was seeing. http://crosreview.com/465189
> >> and the 3 patches above it in case anyone else stumbles on this thread
> >> and is curious.
> >
> > What specific upstream OOM patches are you referring to? I'm always
> > glad to review patches for stable kernels, just email
> > stable@vger.kernel.org the git commit ids and we can take it from there.
>
> +stable
>
> I was wondering about the concept of porting the OOM Reaper back to
> older kernels. The OOM reaper was originally introduced in:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/mm/oom_kill.c?id=aac453635549699c13a84ea1456d5b0e574ef855
>
> Basically the problem described in that patch exists in many older
> kernels and I've certainly seen crashes related to this in 3.10, but I
> believe older kernels see the same problems too.
>
> Personally I wouldn't know exactly which patches were important to
> backport and how far to go. One could arbitrarily try to backport up
> to 4.6.7 (since 4.6 was the first kernel to really have the OOM
> reaper) and ignore all the reaper fixes that landed since then. This
> would probably be doable for kernel 4.4, though if anyone was trying
> to support older kernels it might get harder.
Well, I would need someone to give me a list of commits, and actually
test it to see if it is something that people use/want before I can
queue anything up for a stable release...
{hint}
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-03 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170331175341.19889-1-dianders@chromium.org>
[not found] ` <20170331192944.GB9744@kroah.com>
[not found] ` <CAD=FV=X39vVZ0v2_Z5rDrJt1JcdW+N8jRkhc0bz4yqqtox2=4Q@mail.gmail.com>
[not found] ` <20170401064856.GA14971@kroah.com>
2017-04-02 2:34 ` [RFC PATCH] binder: Don't require the binder lock when killed in binder_thread_read() Doug Anderson
2017-04-03 13:25 ` Greg KH [this message]
2017-04-03 18:09 ` Doug Anderson
2017-04-04 7:40 ` Michal Hocko
2017-04-04 15:10 ` Doug Anderson
2017-04-04 15:29 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403132502.GA32491@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=stable@vger.kernel.org \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).