From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:35786 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753046AbdDCSWB (ORCPT ); Mon, 3 Apr 2017 14:22:01 -0400 Date: Mon, 3 Apr 2017 11:21:57 -0700 From: Eric Biggers To: Mimi Zohar Cc: keyrings@vger.kernel.org, David Howells , Andy Lutomirski , Herbert Xu , Eric Biggers , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] KEYS: encrypted: avoid encrypting/decrypting stack buffers Message-ID: <20170403182157.GC72831@gmail.com> References: <20170401191709.25170-1-ebiggers3@gmail.com> <1491099837.3499.163.camel@linux.vnet.ibm.com> <20170402033349.GA5346@zzz> <1491234942.2928.10.camel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1491234942.2928.10.camel@linux.vnet.ibm.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Apr 03, 2017 at 11:55:42AM -0400, Mimi Zohar wrote: > > This patch removes calculating the "padlen". �Will this change break > other use cases? > No, the number of bytes being encrypted is still 'encrypted_datalen' which is passed to skcipher_request_set_crypt(). It's okay if the input scatterlist is longer than that; only the first 'encrypted_datalen' bytes will be used. - Eric