Re: [PATCH v2 for-4.9 04/32] MIPS: Lantiq: Fix cascaded IRQ setup

[James Hogan <james.hogan@imgtec.com>]

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

On Thu, Apr 06, 2017 at 04:23:24PM +0530, Amit Pundir wrote:
> On 6 April 2017 at 14:59, James Hogan <james.hogan@imgtec.com> wrote:
> > Is there a particular reason this is desired in stable? I was under the
> > impression it was only helpful in the presence of a bug in the separate
> > IRQ stack stuff in 4.11, which was fixed in the above mentioned commit
> > de856416e714 ("MIPS: IRQ Stack: Fix erroneous jal to
> > plat_irq_dispatch"), and otherwise just a nice to have cleanup.
> 
> I picked up this patch from Lede source tree
> https://github.com/lede-project/source/ for stable 4.9.
> 
> >
> > If you've cherry picked the IRQ stack work, have you also cherry-picked
> > de856416e714?
> 
> Thanks for pointing it out. I indeed missed out on picking
> de856416e714 ("MIPS: IRQ Stack: Fix erroneous jal to
> plat_irq_dispatch") and dda45f701c9d ("MIPS: Switch to the irq_stack
> in interrupts"). Should I pick them too for 4.9/4.10 stable or drop
> these 3 IRQ stack patches altogether if they are not stable material?

I'd definitely drop this one.

Greg said he doesn't object to accepting the IRQ stack work once its
been shaken out in mainline, at which point the fixes will be needed
too:

https://marc.info/?l=linux-mips&m=148449064421154&w=2

Though note that its more than just the one patch:

https://patchwork.linux-mips.org/project/linux-mips/list/?series=23&state=*

(I seem to remember somebody saying LEDE had applied these patches).

Cheers
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]