From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:58110 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754388AbdDJQFB (ORCPT
        <rfc822;stable@vger.kernel.org>); Mon, 10 Apr 2017 12:05:01 -0400
Date: Mon, 10 Apr 2017 18:04:51 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: keno@juliacomputing.com, akpm@linux-foundation.org,
        gthelen@google.com, hughd@google.com, keescook@chromium.org,
        kirill.shutemov@linux.intel.com, luto@kernel.org, mhocko@suse.com,
        npiggin@gmail.com, oleg@redhat.com, torvalds@linux-foundation.org,
        w@1wt.eu, stable@vger.kernel.org, stable-commits@vger.kernel.org
Subject: Re: Patch "mm/huge_memory.c: respect FOLL_FORCE/FOLL_COW for thp"
 has been added to the 4.4-stable tree
Message-ID: <20170410160451.GA5425@kroah.com>
References: <14918369578070@kroah.com>
 <1491839297.2409.51.camel@decadent.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1491839297.2409.51.camel@decadent.org.uk>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Mon, Apr 10, 2017 at 04:48:17PM +0100, Ben Hutchings wrote:
> On Mon, 2017-04-10 at 17:09 +0200, gregkh@linuxfoundation.org wrote:
> > This is a note to let you know that I've just added the patch titled
> > 
> > ����mm/huge_memory.c: respect FOLL_FORCE/FOLL_COW for thp
> > 
> > to the 4.4-stable tree which can be found at:
> > ����http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> > �����mm-huge_memory.c-respect-foll_force-foll_cow-for-thp.patch
> > and it can be found in the queue-4.4 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> > 
> > 
> > From 303681d5d538d81b5e23754515202b5b9febd2e9 Mon Sep 17 00:00:00 2001
> > From: Keno Fischer <keno@juliacomputing.com>
> > Date: Tue, 24 Jan 2017 15:17:48 -0800
> > Subject: mm/huge_memory.c: respect FOLL_FORCE/FOLL_COW for thp
> > 
> > From: Keno Fischer <keno@juliacomputing.com>
> > 
> > commit 8310d48b125d19fcd9521d83b8293e63eb1646aa upstream.
> [...]
> > �- Drop change to follow_devmap_pmd()
> > �- pmd_dirty() is not available; check the page flags as in older
> > ���backports of can_follow_write_pte()
> > �- Adjust context]
> [...]
> 
> Aside from the fact that I got this backport wrong, I don't think you
> need the main change here.  In 4.4, all arches that define
> CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE also define pmd_dirty().

Hm, ok, but Keno said people are still hitting this issue on 4.4-stable.

So, what should I do?  I'll go drop this from my queue for now, but as I
don't know what to do to test this, I'm at a loss...

thanks,

greg k-h