From: Greg KH <greg@kroah.com>
To: Martin Brandenburg <martin@omnibond.com>
Cc: hubcap@omnibond.com, stable@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] orangefs: Dan Carpenter influenced cleanups...
Date: Wed, 12 Apr 2017 15:00:21 +0200 [thread overview]
Message-ID: <20170412130021.GA10858@kroah.com> (raw)
In-Reply-To: <20170411164128.8401-3-martin@omnibond.com>
On Tue, Apr 11, 2017 at 12:41:27PM -0400, Martin Brandenburg wrote:
> From: Mike Marshall <hubcap@omnibond.com>
>
> commit 05973c2efb40122f2a9ecde2d065f7ea5068d024 upstream.
>
> This patch is simlar to one Dan Carpenter sent me, cleans
> up some return codes and whitespace errors. There was one
> place where he thought inserting an error message into
> the ring buffer might be too chatty, I hope I convinced him
> othewise. As a consolation <g> I changed a truly chatty
> error message in another location into a debug message,
> system-admins had already yelled at me about that one...
>
> Signed-off-by: Mike Marshall <hubcap@omnibond.com>
>
> I have removed the return code and whitespace fixes as they do not cause
> a real bug. I keep the removal of an error message. This error shows
> up when a process dies before the OrangeFS userspace client responds.
> This happens all the time on production systems and fills up the ring
> buffer.
No, please keep patches identical to what is in Linus's tree. That way
you don't mess something up, and any future patches over the next 2+
years the kernel tree will be around apply cleanly.
Almost every single time we "modify" a patch from what is in Linus's
tree it is broken.
I've taken the original patch here for 4.9 and 4.10 stable trees.
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-12 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 16:41 [PATCH 0/3] orangefs fixes for stable Martin Brandenburg
2017-04-11 16:41 ` [PATCH 1/3] orangefs: fix memory leak of string 'new' on exit path Martin Brandenburg
2017-04-11 16:41 ` [PATCH 2/3] orangefs: Dan Carpenter influenced cleanups Martin Brandenburg
2017-04-12 13:00 ` Greg KH [this message]
2017-04-12 15:27 ` Martin Brandenburg
2017-04-12 20:03 ` Greg KH
2017-04-11 16:41 ` [PATCH 3/3] orangefs: fix buffer size mis-match between kernel space and user space Martin Brandenburg
2017-04-12 13:01 ` [PATCH 0/3] orangefs fixes for stable Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412130021.GA10858@kroah.com \
--to=greg@kroah.com \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).