From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f50.google.com ([74.125.83.50]:33677 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753381AbdDQQWc (ORCPT ); Mon, 17 Apr 2017 12:22:32 -0400 Received: by mail-pg0-f50.google.com with SMTP id 63so14134483pgh.0 for ; Mon, 17 Apr 2017 09:22:32 -0700 (PDT) Date: Mon, 17 Apr 2017 18:22:13 +0200 From: Michael Trimarchi To: Greg KH Cc: sre@kernel.org, linux-pm@vger.kernel.org, stable@vger.kernel.org Subject: Re: [RFC PATCH] pda_power: move from timer to delayed_work Message-ID: <20170417162206.GA31411@panicking> References: <1492420261-25635-1-git-send-email-michael@amarulasolutions.com> <20170417155157.GA12497@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170417155157.GA12497@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: Hi On Mon, Apr 17, 2017 at 05:51:57PM +0200, Greg KH wrote: > On Mon, Apr 17, 2017 at 11:11:01AM +0200, Michael Trimarchi wrote: > > This changed is needed to avoid locking problem during > > boot as shown: > > > > <5>[ 8.824096] Registering SWP/SWPB emulation handler > > <6>[ 8.977294] clock: disabling unused clocks to save power > > <3>[ 9.108154] BUG: sleeping function called from invalid context at kernel_albert/kernel/mutex.c:269 > > <3>[ 9.122894] in_atomic(): 1, irqs_disabled(): 0, pid: 1, name: swapper/0 > > <4>[ 9.130249] 3 locks held by swapper/0/1: > > <4>[ 9.134613] #0: (&__lockdep_no_validate__){......}, at: [] __driver_attach+0x58/0xa8 > > <4>[ 9.144500] #1: (&__lockdep_no_validate__){......}, at: [] __driver_attach+0x68/0xa8 > > <4>[ 9.154357] #2: (&polling_timer){......}, at: [] run_timer_softirq+0x108/0x3ec > > <4>[ 9.163726] Backtrace: > > <4>[ 9.166473] [] (dump_backtrace+0x0/0x114) from [] (dump_stack+0x20/0x24) > > <4>[ 9.175811] r6:00203230 r5:0000010d r4:d782e000 r3:60000113 > > <4>[ 9.182250] [] (dump_stack+0x0/0x24) from [] (__might_sleep+0x10c/0x128) > > <4>[ 9.191650] [] (__might_sleep+0x0/0x128) from [] (mutex_lock_nested+0x34/0x36c) > > <4>[ 9.201660] r5:c02d5350 r4:d79a0c64 > > <4>[ 9.205688] [] (mutex_lock_nested+0x0/0x36c) from [] (regulator_set_current_limit+0x30/0x118) > > <4>[ 9.217071] [] (regulator_set_current_limit+0x0/0x118) from [] (update_charger+0x84/0xc4) > > <4>[ 9.228027] r7:d782fb20 r6:00000101 r5:c1767e94 r4:00000000 > > <4>[ 9.234436] [] (update_charger+0x0/0xc4) from [] (psy_changed+0x20/0x48) > > <4>[ 9.243804] r5:d782e000 r4:c1767e94 > > <4>[ 9.247802] [] (psy_changed+0x0/0x48) from [] (polling_timer_func+0x84/0xb8) > > <4>[ 9.257537] r4:c1767e94 r3:00000002 > > <4>[ 9.261566] [] (polling_timer_func+0x0/0xb8) from [] (run_timer_softirq+0x17c/0x3ec) > > <4>[ 9.272033] r4:c1767eb0 r3:00000000 > > <4>[ 9.276062] [] (run_timer_softirq+0x0/0x3ec) from [] (__do_softirq+0xf0/0x298) > > <4>[ 9.286010] [] (__do_softirq+0x0/0x298) from [] (irq_exit+0x98/0xa0) > > <4>[ 9.295013] [] (irq_exit+0x0/0xa0) from [] (handle_IRQ+0x60/0xc0) > > <4>[ 9.303680] r4:c1194e98 r3:c00bc778 > > <4>[ 9.307708] [] (handle_IRQ+0x0/0xc0) from [] (gic_handle_irq+0x34/0x68) > > <4>[ 9.316955] r8:000ac383 r7:d782fc3c r6:d782fc08 r5:c11936c4 r4:e0802100 > > <4>[ 9.324310] r3:c026ba48 > > <4>[ 9.327301] [] (gic_handle_irq+0x0/0x68) from [] (__irq_svc+0x40/0x74) > > <4>[ 9.336456] Exception stack(0xd782fc08 to 0xd782fc50) > > <4>[ 9.342041] fc00: d6e30e6c ac383627 00000000 ac383417 ea19c000 ea200000 > > <4>[ 9.351104] fc20: beffffff 00000667 000ac383 d6e30670 d6e3066c d782fc94 d782fbe8 d782fc50 > > <4>[ 9.360168] fc40: c026ba48 c001d1f0 00000113 ffffffff > > > > Signed-off-by: Michael Trimarchi > > --- > > drivers/power/supply/pda_power.c | 48 ++++++++++++++++++++++------------------ > > 1 file changed, 26 insertions(+), 22 deletions(-) > > > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > for how to do this properly. > > Ok, clear enough and I will read the documentation and proper re-submit it. Is it clear enough to have some brief review process on linux-pm? Michael