From: Minchan Kim <minchan@kernel.org>
To: <gregkh@linuxfoundation.org>
Cc: <akpm@linux-foundation.org>, <sergey.senozhatsky@gmail.com>,
<torvalds@linux-foundation.org>, <stable@vger.kernel.org>,
<stable-commits@vger.kernel.org>
Subject: Re: Patch "zram: fix operator precedence to get offset" has been added to the 4.9-stable tree
Date: Wed, 19 Apr 2017 10:04:21 +0900 [thread overview]
Message-ID: <20170419010421.GG19929@bbox> (raw)
In-Reply-To: <149251984225412@kroah.com>
On Tue, Apr 18, 2017 at 02:50:42PM +0200, gregkh@linuxfoundation.org wrote:
>
> This is a note to let you know that I've just added the patch titled
>
> zram: fix operator precedence to get offset
>
> to the 4.9-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
> zram-fix-operator-precedence-to-get-offset.patch
> and it can be found in the queue-4.9 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
>
>
> From 4ca82dabc9fbf7bc5322aa54d802cb3cb7b125c5 Mon Sep 17 00:00:00 2001
> From: Minchan Kim <minchan@kernel.org>
> Date: Thu, 13 Apr 2017 14:56:35 -0700
> Subject: zram: fix operator precedence to get offset
>
> From: Minchan Kim <minchan@kernel.org>
>
> commit 4ca82dabc9fbf7bc5322aa54d802cb3cb7b125c5 upstream.
>
> In zram_rw_page, the logic to get offset is wrong by operator precedence
> (i.e., "<<" is higher than "&"). With wrong offset, zram can corrupt
> the user's data. This patch fixes it.
>
> Fixes: 8c7f01025 ("zram: implement rw_page operation of zram")
> Link: http://lkml.kernel.org/r/1492042622-12074-1-git-send-email-minchan@kernel.org
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
After Linus merging this patch, I got realized that patch itself is correct
but no need to apply this patch to the stable by review from Sergey.
Please drop this patch.
Sorry for the noise caused by zram.
prev parent reply other threads:[~2017-04-19 1:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 12:50 Patch "zram: fix operator precedence to get offset" has been added to the 4.9-stable tree gregkh
2017-04-19 1:04 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419010421.GG19929@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).