* Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
[not found] ` <1479710246-26676-8-git-send-email-riteshh@codeaurora.org>
@ 2017-04-26 21:44 ` Andy Gross
2017-04-27 7:58 ` Georgi Djakov
2017-04-27 9:03 ` Ulf Hansson
0 siblings, 2 replies; 8+ messages in thread
From: Andy Gross @ 2017-04-26 21:44 UTC (permalink / raw)
To: Ritesh Harjani
Cc: ulf.hansson, linux-mmc, adrian.hunter, sboyd, shawn.lin,
devicetree, linux-clk, david.brown, linux-arm-msm, georgi.djakov,
alex.lemberg, mateusz.nowak, Yuliy.Izrailov, asutoshd,
david.griego, stummala, venkatg, rnayak, pramod.gurav, jeremymc,
stable
On Mon, Nov 21, 2016 at 12:07:17PM +0530, Ritesh Harjani wrote:
> This add get_min_clock() and get_max_clock() callback
> for sdhci-msm. sdhci-msm min/max clocks may be different
> hence implement these callbacks.
>
> Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
This patch needs to be picked up for stable as 4.9 is currently broken w.r.t.
MMC on Qualcomm platforms.
Fixes: d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")
Regards,
Andy Gross
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
2017-04-26 21:44 ` [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback Andy Gross
@ 2017-04-27 7:58 ` Georgi Djakov
2017-04-27 9:03 ` Ulf Hansson
1 sibling, 0 replies; 8+ messages in thread
From: Georgi Djakov @ 2017-04-27 7:58 UTC (permalink / raw)
To: Andy Gross, stable
Cc: Ritesh Harjani, ulf.hansson, linux-mmc, adrian.hunter, sboyd,
shawn.lin, devicetree, linux-clk, david.brown, linux-arm-msm,
georgi.djakov, alex.lemberg, mateusz.nowak, Yuliy.Izrailov,
asutoshd, david.griego, stummala, venkatg, rnayak, pramod.gurav,
jeremymc
On 04/27/2017 12:44 AM, Andy Gross wrote:
> On Mon, Nov 21, 2016 at 12:07:17PM +0530, Ritesh Harjani wrote:
>> This add get_min_clock() and get_max_clock() callback
>> for sdhci-msm. sdhci-msm min/max clocks may be different
>> hence implement these callbacks.
>>
>> Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
>> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> This patch needs to be picked up for stable as 4.9 is currently broken w.r.t.
> MMC on Qualcomm platforms.
>
> Fixes: d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")
Agree! Applying this patch (80031bdeb764) in stable fixes the
broken mmc. Otherwise the following error is seen since v4.9.22:
mmc0: Hardware doesn't specify base clock frequency.
Thanks,
Georgi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
2017-04-26 21:44 ` [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback Andy Gross
2017-04-27 7:58 ` Georgi Djakov
@ 2017-04-27 9:03 ` Ulf Hansson
2017-04-27 9:52 ` Greg Kroah-Hartman
1 sibling, 1 reply; 8+ messages in thread
From: Ulf Hansson @ 2017-04-27 9:03 UTC (permalink / raw)
To: Andy Gross, Greg Kroah-Hartman
Cc: Ritesh Harjani, linux-mmc@vger.kernel.org, Adrian Hunter,
linux-arm-msm@vger.kernel.org, Georgi Djakov, Sahitya Tummala,
Venkat Gopalakrishnan, Rajendra Nayak, Pramod Gurav, jeremymc,
# 4.0+
+Greg
-trimmed cc
On 26 April 2017 at 23:44, Andy Gross <andy.gross@linaro.org> wrote:
> On Mon, Nov 21, 2016 at 12:07:17PM +0530, Ritesh Harjani wrote:
>> This add get_min_clock() and get_max_clock() callback
>> for sdhci-msm. sdhci-msm min/max clocks may be different
>> hence implement these callbacks.
>>
>> Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
>> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> This patch needs to be picked up for stable as 4.9 is currently broken w.r.t.
> MMC on Qualcomm platforms.
>
> Fixes: d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")
>
> Regards,
>
> Andy Gross
I did a quick investigation around this.
So for some reason Greg decided to pick up the original commit,
a0e3142869d2 ("mmc: sdhci-msm: Enable few quirks"), for 4.9 stable
[1], even if that patch wasn't sent or tagged for stable.
It was a mistake, as simple as that - and I should also have spotted
it when Greg posted his stable-review series, sorry.
For clarification, the original commit a0e3142869d2 ("mmc: sdhci-msm:
Enable few quirks"), is present in 4.10 together with $subject patch.
So the regression is present only in 4.9 stable.
Greg, can you pick up @subject patch for stable according to Andy's
suggestion or you want some of us to re-post it to stable?
Kind regards
Uffe
[1]
https://www.spinics.net/lists/stable/msg167259.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
2017-04-27 9:03 ` Ulf Hansson
@ 2017-04-27 9:52 ` Greg Kroah-Hartman
2017-04-27 10:29 ` Georgi Djakov
0 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2017-04-27 9:52 UTC (permalink / raw)
To: Ulf Hansson
Cc: Andy Gross, Ritesh Harjani, linux-mmc@vger.kernel.org,
Adrian Hunter, linux-arm-msm@vger.kernel.org, Georgi Djakov,
Sahitya Tummala, Venkat Gopalakrishnan, Rajendra Nayak,
Pramod Gurav, jeremymc, # 4.0+
On Thu, Apr 27, 2017 at 11:03:08AM +0200, Ulf Hansson wrote:
> +Greg
> -trimmed cc
>
> On 26 April 2017 at 23:44, Andy Gross <andy.gross@linaro.org> wrote:
> > On Mon, Nov 21, 2016 at 12:07:17PM +0530, Ritesh Harjani wrote:
> >> This add get_min_clock() and get_max_clock() callback
> >> for sdhci-msm. sdhci-msm min/max clocks may be different
> >> hence implement these callbacks.
> >>
> >> Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
> >> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
> >> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> >
> > This patch needs to be picked up for stable as 4.9 is currently broken w.r.t.
> > MMC on Qualcomm platforms.
> >
> > Fixes: d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")
> >
> > Regards,
> >
> > Andy Gross
>
> I did a quick investigation around this.
>
> So for some reason Greg decided to pick up the original commit,
> a0e3142869d2 ("mmc: sdhci-msm: Enable few quirks"), for 4.9 stable
> [1], even if that patch wasn't sent or tagged for stable.
> It was a mistake, as simple as that - and I should also have spotted
> it when Greg posted his stable-review series, sorry.
>
> For clarification, the original commit a0e3142869d2 ("mmc: sdhci-msm:
> Enable few quirks"), is present in 4.10 together with $subject patch.
> So the regression is present only in 4.9 stable.
>
> Greg, can you pick up @subject patch for stable according to Andy's
> suggestion or you want some of us to re-post it to stable?
Sorry about this. What git commit should I take for this from Linus's
tree for the 4.9-stable tree? Or if there isn't one, I'll be glad to
just revert this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
2017-04-27 9:52 ` Greg Kroah-Hartman
@ 2017-04-27 10:29 ` Georgi Djakov
2017-04-27 11:44 ` Greg Kroah-Hartman
0 siblings, 1 reply; 8+ messages in thread
From: Georgi Djakov @ 2017-04-27 10:29 UTC (permalink / raw)
To: Greg Kroah-Hartman, Ulf Hansson
Cc: Andy Gross, Ritesh Harjani, linux-mmc@vger.kernel.org,
Adrian Hunter, linux-arm-msm@vger.kernel.org, Sahitya Tummala,
Venkat Gopalakrishnan, Rajendra Nayak, Pramod Gurav, jeremymc,
# 4.0+
On 04/27/2017 12:52 PM, Greg Kroah-Hartman wrote:
> On Thu, Apr 27, 2017 at 11:03:08AM +0200, Ulf Hansson wrote:
>> +Greg
>> -trimmed cc
>>
>> On 26 April 2017 at 23:44, Andy Gross <andy.gross@linaro.org> wrote:
>>> On Mon, Nov 21, 2016 at 12:07:17PM +0530, Ritesh Harjani wrote:
>>>> This add get_min_clock() and get_max_clock() callback
>>>> for sdhci-msm. sdhci-msm min/max clocks may be different
>>>> hence implement these callbacks.
>>>>
>>>> Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
>>>> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
>>>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>>>
>>> This patch needs to be picked up for stable as 4.9 is currently broken w.r.t.
>>> MMC on Qualcomm platforms.
>>>
>>> Fixes: d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")
>>>
>>> Regards,
>>>
>>> Andy Gross
>>
>> I did a quick investigation around this.
>>
>> So for some reason Greg decided to pick up the original commit,
>> a0e3142869d2 ("mmc: sdhci-msm: Enable few quirks"), for 4.9 stable
>> [1], even if that patch wasn't sent or tagged for stable.
>> It was a mistake, as simple as that - and I should also have spotted
>> it when Greg posted his stable-review series, sorry.
>>
>> For clarification, the original commit a0e3142869d2 ("mmc: sdhci-msm:
>> Enable few quirks"), is present in 4.10 together with $subject patch.
>> So the regression is present only in 4.9 stable.
>>
>> Greg, can you pick up @subject patch for stable according to Andy's
>> suggestion or you want some of us to re-post it to stable?
>
> Sorry about this. What git commit should I take for this from Linus's
> tree for the 4.9-stable tree? Or if there isn't one, I'll be glad to
> just revert this.
>
Thanks Greg and Ulf,
A revert of d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks") would be
the best solution.
The other option is to pick 80031bdeb764 ("mmc: sdhci-msm: Add
get_min_clock() and get_max_clock() callback").
BR,
Georgi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
2017-04-27 10:29 ` Georgi Djakov
@ 2017-04-27 11:44 ` Greg Kroah-Hartman
2017-04-27 15:34 ` Ritesh Harjani
2017-04-27 20:11 ` Andy Gross
0 siblings, 2 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2017-04-27 11:44 UTC (permalink / raw)
To: Georgi Djakov
Cc: Ulf Hansson, Andy Gross, Ritesh Harjani,
linux-mmc@vger.kernel.org, Adrian Hunter,
linux-arm-msm@vger.kernel.org, Sahitya Tummala,
Venkat Gopalakrishnan, Rajendra Nayak, Pramod Gurav, jeremymc,
# 4.0+
On Thu, Apr 27, 2017 at 01:29:22PM +0300, Georgi Djakov wrote:
> On 04/27/2017 12:52 PM, Greg Kroah-Hartman wrote:
> > On Thu, Apr 27, 2017 at 11:03:08AM +0200, Ulf Hansson wrote:
> >> +Greg
> >> -trimmed cc
> >>
> >> On 26 April 2017 at 23:44, Andy Gross <andy.gross@linaro.org> wrote:
> >>> On Mon, Nov 21, 2016 at 12:07:17PM +0530, Ritesh Harjani wrote:
> >>>> This add get_min_clock() and get_max_clock() callback
> >>>> for sdhci-msm. sdhci-msm min/max clocks may be different
> >>>> hence implement these callbacks.
> >>>>
> >>>> Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
> >>>> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
> >>>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> >>>
> >>> This patch needs to be picked up for stable as 4.9 is currently broken w.r.t.
> >>> MMC on Qualcomm platforms.
> >>>
> >>> Fixes: d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")
> >>>
> >>> Regards,
> >>>
> >>> Andy Gross
> >>
> >> I did a quick investigation around this.
> >>
> >> So for some reason Greg decided to pick up the original commit,
> >> a0e3142869d2 ("mmc: sdhci-msm: Enable few quirks"), for 4.9 stable
> >> [1], even if that patch wasn't sent or tagged for stable.
> >> It was a mistake, as simple as that - and I should also have spotted
> >> it when Greg posted his stable-review series, sorry.
> >>
> >> For clarification, the original commit a0e3142869d2 ("mmc: sdhci-msm:
> >> Enable few quirks"), is present in 4.10 together with $subject patch.
> >> So the regression is present only in 4.9 stable.
> >>
> >> Greg, can you pick up @subject patch for stable according to Andy's
> >> suggestion or you want some of us to re-post it to stable?
> >
> > Sorry about this. What git commit should I take for this from Linus's
> > tree for the 4.9-stable tree? Or if there isn't one, I'll be glad to
> > just revert this.
> >
>
> Thanks Greg and Ulf,
>
> A revert of d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks") would be
> the best solution.
>
> The other option is to pick 80031bdeb764 ("mmc: sdhci-msm: Add
> get_min_clock() and get_max_clock() callback").
I've reverted it now, thanks.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
2017-04-27 11:44 ` Greg Kroah-Hartman
@ 2017-04-27 15:34 ` Ritesh Harjani
2017-04-27 20:11 ` Andy Gross
1 sibling, 0 replies; 8+ messages in thread
From: Ritesh Harjani @ 2017-04-27 15:34 UTC (permalink / raw)
To: Greg Kroah-Hartman, Ulf Hansson
Cc: Georgi Djakov, Andy Gross, linux-mmc@vger.kernel.org,
Adrian Hunter, linux-arm-msm@vger.kernel.org, Sahitya Tummala,
Venkat Gopalakrishnan, Rajendra Nayak, Pramod Gurav, jeremymc,
# 4.0+
On 4/27/2017 5:14 PM, Greg Kroah-Hartman wrote:
> On Thu, Apr 27, 2017 at 01:29:22PM +0300, Georgi Djakov wrote:
>> On 04/27/2017 12:52 PM, Greg Kroah-Hartman wrote:
>>> On Thu, Apr 27, 2017 at 11:03:08AM +0200, Ulf Hansson wrote:
>>>> +Greg
>>>> -trimmed cc
>>>>
>>>> On 26 April 2017 at 23:44, Andy Gross <andy.gross@linaro.org> wrote:
>>>>> On Mon, Nov 21, 2016 at 12:07:17PM +0530, Ritesh Harjani wrote:
>>>>>> This add get_min_clock() and get_max_clock() callback
>>>>>> for sdhci-msm. sdhci-msm min/max clocks may be different
>>>>>> hence implement these callbacks.
>>>>>>
>>>>>> Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
>>>>>> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
>>>>>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>>>>>
>>>>> This patch needs to be picked up for stable as 4.9 is currently broken w.r.t.
>>>>> MMC on Qualcomm platforms.
>>>>>
>>>>> Fixes: d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")
>>>>>
>>>>> Regards,
>>>>>
>>>>> Andy Gross
>>>>
>>>> I did a quick investigation around this.
>>>>
>>>> So for some reason Greg decided to pick up the original commit,
>>>> a0e3142869d2 ("mmc: sdhci-msm: Enable few quirks"), for 4.9 stable
>>>> [1], even if that patch wasn't sent or tagged for stable.
>>>> It was a mistake, as simple as that - and I should also have spotted
>>>> it when Greg posted his stable-review series, sorry.
>>>>
>>>> For clarification, the original commit a0e3142869d2 ("mmc: sdhci-msm:
>>>> Enable few quirks"), is present in 4.10 together with $subject patch.
>>>> So the regression is present only in 4.9 stable.
>>>>
>>>> Greg, can you pick up @subject patch for stable according to Andy's
>>>> suggestion or you want some of us to re-post it to stable?
>>>
>>> Sorry about this. What git commit should I take for this from Linus's
>>> tree for the 4.9-stable tree? Or if there isn't one, I'll be glad to
>>> just revert this.
>>>
>>
>> Thanks Greg and Ulf,
>>
>> A revert of d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks") would be
>> the best solution.
>>
>> The other option is to pick 80031bdeb764 ("mmc: sdhci-msm: Add
>> get_min_clock() and get_max_clock() callback").
>
> I've reverted it now, thanks.
Thanks Ulf, Greg and all.
Regards
Ritesh
>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
2017-04-27 11:44 ` Greg Kroah-Hartman
2017-04-27 15:34 ` Ritesh Harjani
@ 2017-04-27 20:11 ` Andy Gross
1 sibling, 0 replies; 8+ messages in thread
From: Andy Gross @ 2017-04-27 20:11 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Georgi Djakov, Ulf Hansson, Ritesh Harjani,
linux-mmc@vger.kernel.org, Adrian Hunter,
linux-arm-msm@vger.kernel.org, Sahitya Tummala,
Venkat Gopalakrishnan, Rajendra Nayak, Pramod Gurav, jeremymc,
# 4.0+
On Thu, Apr 27, 2017 at 01:44:41PM +0200, Greg Kroah-Hartman wrote:
> I've reverted it now, thanks.
Thanks Greg!
Regards,
Andy
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-04-27 20:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1479710246-26676-1-git-send-email-riteshh@codeaurora.org>
[not found] ` <1479710246-26676-8-git-send-email-riteshh@codeaurora.org>
2017-04-26 21:44 ` [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback Andy Gross
2017-04-27 7:58 ` Georgi Djakov
2017-04-27 9:03 ` Ulf Hansson
2017-04-27 9:52 ` Greg Kroah-Hartman
2017-04-27 10:29 ` Georgi Djakov
2017-04-27 11:44 ` Greg Kroah-Hartman
2017-04-27 15:34 ` Ritesh Harjani
2017-04-27 20:11 ` Andy Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).