From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:47689 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbdEDP2R (ORCPT ); Thu, 4 May 2017 11:28:17 -0400 Date: Thu, 4 May 2017 09:15:26 -0600 From: Scott Bauer To: Bart Van Assche Cc: "hch@lst.de" , "linux-scsi@vger.kernel.org" , "James.Bottomley@HansenPartnership.com" , "jack@suse.cz" , "hare@suse.com" , "martin.petersen@oracle.com" , "stable@vger.kernel.org" Subject: Re: [PATCH v2] Avoid that scsi_exit_rq() triggers a use-after-free Message-ID: <20170504151525.GA16489@sbauer-Z170X-UD5> References: <20170503180911.24326-1-bart.vanassche@sandisk.com> <20170504073013.GA3684@lst.de> <1493911596.2692.2.camel@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493911596.2692.2.camel@sandisk.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, May 04, 2017 at 03:26:37PM +0000, Bart Van Assche wrote: > On Thu, 2017-05-04 at 09:30 +0200, Christoph Hellwig wrote: > > Please just add a flag to ->flags instead of adding a whole new field. > > > > Otherwise this looks good to me. > > Hello Christoph, > > Thanks for the feedback. I will make the proposed change and post a second > version. > > Bart. BTW, what branch was your last patch based off? I had some hunk errors while applying it.