From: Stephen Hemminger <stephen@networkplumber.org>
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org,
Stephen Hemminger <sthemmin@microsoft.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: storvsc: Workaround for virtual DVD SCSI version
Date: Thu, 4 May 2017 17:03:50 -0700 [thread overview]
Message-ID: <20170504170350.1fb28a94@xeon-e3> (raw)
In-Reply-To: <20170504193342.GB5095@kroah.com>
On Thu, 4 May 2017 12:33:42 -0700
Greg KH <greg@kroah.com> wrote:
> On Wed, May 03, 2017 at 03:56:32PM -0700, Stephen Hemminger wrote:
> > From: Stephen Hemminger <stephen@networkplumber.org>
> >
> > commit f1c635b439a5c01776fe3a25b1e2dc546ea82e6f upstream
> >
> > Hyper-V host emulation of SCSI for virtual DVD device reports SCSI
> > version 0 (UNKNOWN) but is still capable of supporting REPORTLUN.
> >
> > Without this patch, a GEN2 Linux guest on Hyper-V will not boot
> > successfully with virtual DVD ROM device. What happens is that the SCSI
> > scan process falls back to doing sequential probing by INQUIRY. But the
> > storvsc driver has a previous workaround that masks/blocks all errors
> > reports from INQUIRY (or MODE_SENSE) commands. This workaround causes
> > the scan to then populate a full set of bogus LUN's on the target and
> > then sends kernel spinning off into a death spiral doing block reads on
> > the non-existent LUNs.
> >
> > By setting the correct blacklist flags, the target with the DVD device
> > is scanned with REPORTLUN which works correctly.
> >
> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> > Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> > ---
> > drivers/scsi/storvsc_drv.c | 27 +++++++++++++++++----------
> > 1 file changed, 17 insertions(+), 10 deletions(-)
>
> I've queued this up, but it's interesting how you deleted the changelog
> comments here saying this was only needed for 4.11 and no older kernels
> :)
At the time I only had reports of problem with 4.11.
But others ran into issue with 4.10 and 4.9
prev parent reply other threads:[~2017-05-05 0:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 22:56 [PATCH] scsi: storvsc: Workaround for virtual DVD SCSI version Stephen Hemminger
2017-05-04 19:33 ` Greg KH
2017-05-05 0:03 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504170350.1fb28a94@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=greg@kroah.com \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox