stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: stable@vger.kernel.org,
	James Hughes <james.hughes@raspberrypi.org>,
	Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH stable-4.4 1/2] brcmfmac: Ensure pointer correctly set if skb data location changes
Date: Tue, 9 May 2017 14:29:23 +0200	[thread overview]
Message-ID: <20170509122923.GA6953@kroah.com> (raw)
In-Reply-To: <edb40a45-b37b-2fef-8094-1e4cbad24956@broadcom.com>

On Tue, May 09, 2017 at 02:17:59PM +0200, Arend Van Spriel wrote:
> 
> 
> On 9-5-2017 14:14, Greg KH wrote:
> > On Tue, May 09, 2017 at 11:21:13AM +0100, Arend van Spriel wrote:
> >> From: James Hughes <james.hughes@raspberrypi.org>
> >>
> >> commit 455a1eb4654c24560eb9dfc634f29cba3d87601e upstream
> >>
> >> The incoming skb header may be resized if header space is
> >> insufficient, which might change the data adddress in the skb.
> >> Ensure that a cached pointer to that data is correctly set by
> >> moving assignment to after any possible changes.
> >>
> >> Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
> >> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> >> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> >> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> >> ---
> >> This patch should be applied to the linux-4.4.y and linux-4.1.y
> >> branches.
> > 
> > Now applied to the 4.4 trees.  I've also added it to 3.18, thanks for
> > the patches!
> 
> Ok. I did not check 3.18 as it is marked EOL on kernel.org. I checked
> just now and the patch does not apply to 3.18 as is.

Well, I renamed the file in the diff and all was fine :)

And yes, it does say EOL on kernel.org, I'm just maintaining it on my
own for a bit, no need for you to take extra time on your end.

thanks,

greg k-h

  parent reply	other threads:[~2017-05-09 12:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09 10:21 [PATCH stable-4.4 1/2] brcmfmac: Ensure pointer correctly set if skb data location changes Arend van Spriel
2017-05-09 10:21 ` [PATCH stable-4.4 2/2] brcmfmac: Make skb header writable before use Arend van Spriel
2017-05-09 12:14 ` [PATCH stable-4.4 1/2] brcmfmac: Ensure pointer correctly set if skb data location changes Greg KH
2017-05-09 12:17   ` Arend Van Spriel
2017-05-09 12:29     ` Arend Van Spriel
2017-05-09 12:29     ` Greg KH [this message]
2017-05-09 18:17       ` Arend Van Spriel
2017-05-09 19:13         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170509122923.GA6953@kroah.com \
    --to=greg@kroah.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=james.hughes@raspberrypi.org \
    --cc=kvalo@codeaurora.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).