From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:41548 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbdELNKc (ORCPT ); Fri, 12 May 2017 09:10:32 -0400 Date: Fri, 12 May 2017 15:10:22 +0200 From: Greg Kroah-Hartman To: Johan Hovold Cc: Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 4.4 38/60] USB: serial: sierra: fix bogus alternate-setting assumption Message-ID: <20170512131022.GA13103@kroah.com> References: <20170511141237.094835992@linuxfoundation.org> <20170511141238.714173568@linuxfoundation.org> <1494588377.3965.66.camel@codethink.co.uk> <20170512121403.GQ30445@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170512121403.GQ30445@localhost> Sender: stable-owner@vger.kernel.org List-ID: On Fri, May 12, 2017 at 02:14:03PM +0200, Johan Hovold wrote: > On Fri, May 12, 2017 at 12:26:17PM +0100, Ben Hutchings wrote: > > On Thu, 2017-05-11 at 16:13 +0200, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > > > ------------------ > > > > > > From: Johan Hovold > > > > > > commit 16620b483eaf7750413bae472f4363b6b959fcaa upstream. > > > > > > Interface numbers do not change when enabling alternate settings as > > > comment and code in this driver suggested. > > > > > > Remove the confusing comment and redundant retrieval of the interface > > > number in probe, while simplifying and renaming the interface-number > > > helper. > > > > This looks like cleanup with no functional impact, so unless it's needed > > as preparation for something else I think it should be dropped. > > Indeed, this one is not needed in -stable. Ah, my fault, I thought this was fixing an issue there, sorry about that. Now removed from all of the queues, thanks Ben. greg k-h