From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Zhang Yi <yizhan@redhat.com>,
linux-block@vger.kernel.org,
Johannes Thumshirn <jthumshirn@suse.de>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/3] nvme: use blk_mq_start_hw_queues() in nvme_kill_queues()
Date: Sun, 21 May 2017 08:20:02 +0200 [thread overview]
Message-ID: <20170521062002.GB12287@lst.de> (raw)
In-Reply-To: <20170520035605.21785-2-ming.lei@redhat.com>
> index d5e0906262ea..ce0d96913ee6 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -2437,7 +2437,13 @@ void nvme_kill_queues(struct nvme_ctrl *ctrl)
> revalidate_disk(ns->disk);
> blk_set_queue_dying(ns->queue);
> blk_mq_abort_requeue_list(ns->queue);
> - blk_mq_start_stopped_hw_queues(ns->queue, true);
> +
> + /*
> + * We have to force to start queues for avoiding hang
> + * forever, and we have to make sure that queues won't
> + * be stopped forever from now on.
> + */
/*
* Forcibly start all queues to avoid having stuck requests.
* Note: We must make sure to not stop the queues from
* now until the final removal.
*/
Otherwise this looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-05-21 6:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170520035605.21785-1-ming.lei@redhat.com>
2017-05-20 3:56 ` [PATCH v2 1/3] nvme: use blk_mq_start_hw_queues() in nvme_kill_queues() Ming Lei
2017-05-21 6:20 ` Christoph Hellwig [this message]
2017-05-22 1:35 ` Ming Lei
2017-05-22 12:51 ` Christoph Hellwig
2017-05-22 14:49 ` Ming Lei
2017-05-22 5:35 ` Keith Busch
2017-05-22 7:41 ` Johannes Thumshirn
2017-05-20 3:56 ` [PATCH v2 2/3] nvme: avoid to use blk_mq_abort_requeue_list() Ming Lei
2017-05-20 5:34 ` Ming Lei
2017-05-21 6:22 ` Christoph Hellwig
2017-05-22 7:42 ` Johannes Thumshirn
2017-05-22 5:35 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521062002.GB12287@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=yizhan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).