From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: dmaengine@vger.kernel.org
Cc: Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
stable@vger.kernel.org
Subject: [PATCH v3 1/2] dmaengine: ep93xx: Always start from BASE0
Date: Mon, 22 May 2017 16:05:22 +0200 [thread overview]
Message-ID: <20170522140523.24281-2-alexander.sverdlin@gmail.com> (raw)
In-Reply-To: <20170522140523.24281-1-alexander.sverdlin@gmail.com>
The current buffer is being reset to zero on device_free_chan_resources()
but not on device_terminate_all(). It could happen that HW is restarted and
expects BASE0 to be used, but the driver is not synchronized and will start
from BASE1. One solution is to reset the buffer explicitly in
m2p_hw_setup().
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc: stable@vger.kernel.org
---
drivers/dma/ep93xx_dma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
index d37e8dda8079..deb009c3121f 100644
--- a/drivers/dma/ep93xx_dma.c
+++ b/drivers/dma/ep93xx_dma.c
@@ -323,6 +323,8 @@ static int m2p_hw_setup(struct ep93xx_dma_chan *edmac)
| M2P_CONTROL_ENABLE;
m2p_set_control(edmac, control);
+ edmac->buffer = 0;
+
return 0;
}
--
2.12.2
next parent reply other threads:[~2017-05-22 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170522140523.24281-1-alexander.sverdlin@gmail.com>
2017-05-22 14:05 ` Alexander Sverdlin [this message]
2017-05-22 14:05 ` [PATCH v3 2/2] dmaengine: ep93xx: Don't drain the transfers in terminate_all() Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522140523.24281-2-alexander.sverdlin@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox