From: Ingo Molnar <mingo@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Rik van Riel <riel@redhat.com>,
James Hartsock <hartsjc@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
stable@vger.kernel.org, Tim Wright <tim@binbash.co.uk>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 0/2] nohz: Deal with clock reprogram skipping issues v3
Date: Tue, 23 May 2017 09:25:08 +0200 [thread overview]
Message-ID: <20170523072508.3bzyipgwnyjcbef6@gmail.com> (raw)
In-Reply-To: <1495201910-12466-1-git-send-email-fweisbec@gmail.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> v2 had issues on -tip tree and triggered a warning. It seems to have
> disappeared. Perhaps it was due to another timer issue. Anyway this
> version brings more debugging informations, with a layout that is more
> bisection-friendly and it also handles ticks that fire outside IRQ
> context and thus carry NULL irq regs. This happen when
> hrtimer_interrupt() is called on hotplug cpu down for example.
>
> We'll see if the issue arises again.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> nohz/fixes
>
> HEAD: cd15f46b284f04dbedd065a9d99a4e0badae379a
>
> Thanks,
> Frederic
> ---
>
> Frederic Weisbecker (2):
> nohz: Add hrtimer sanity check
> nohz: Fix collision between tick and other hrtimers, again
>
>
> kernel/time/tick-sched.c | 48 +++++++++++++++++++++++++++++++++++++++++++-----
> kernel/time/tick-sched.h | 2 ++
> 2 files changed, 45 insertions(+), 5 deletions(-)
So I think the 3 commits queued up right now:
99fa871820cf: nohz: Reset next_tick cache even when the timer has no regs
411fe24e6b7c: nohz: Fix collision between tick and other hrtimers, again
ce6cf9a15d62: nohz: Add hrtimer sanity check
are OK and I'd not rebase them unless there's some breakage.
One thing I noticed: your second series does appear to have:
99fa871820cf: nohz: Reset next_tick cache even when the timer has no regs
is that intentional? That is pretty much the only commit I'd love to rebase with a
proper description added.
Thanks,
Ingo
next prev parent reply other threads:[~2017-05-23 7:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 13:51 [PATCH 0/2] nohz: Deal with clock reprogram skipping issues v3 Frederic Weisbecker
2017-05-19 13:51 ` [PATCH 1/2] nohz: Add hrtimer sanity check Frederic Weisbecker
2017-05-19 13:51 ` [PATCH 2/2] nohz: Fix collision between tick and other hrtimers, again Frederic Weisbecker
2017-05-23 7:25 ` Ingo Molnar [this message]
2017-05-23 13:10 ` [PATCH 0/2] nohz: Deal with clock reprogram skipping issues v3 Frederic Weisbecker
2017-05-24 7:16 ` Ingo Molnar
2017-05-24 13:28 ` Frederic Weisbecker
2017-05-26 2:10 ` Frederic Weisbecker
2017-05-26 6:13 ` Ingo Molnar
2017-05-29 13:55 ` Frederic Weisbecker
2017-05-30 5:47 ` Ingo Molnar
2017-05-30 12:51 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523072508.3bzyipgwnyjcbef6@gmail.com \
--to=mingo@kernel.org \
--cc=fweisbec@gmail.com \
--cc=hartsjc@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tim@binbash.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).