From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: stable@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH 1/2] ext4 crypto: don't let data integrity writebacks fail with ENOMEM
Date: Tue, 23 May 2017 12:13:44 +0200 [thread overview]
Message-ID: <20170523101344.GA28565@kroah.com> (raw)
In-Reply-To: <20170522233752.109220-1-ebiggers3@gmail.com>
On Mon, May 22, 2017 at 04:37:51PM -0700, Eric Biggers wrote:
> From: Theodore Ts'o <tytso@mit.edu>
>
> commit c9af28fdd44922a6c10c9f8315718408af98e315 upstream. [Please apply
> to 4.4-stable. This fixes a bug which has caused problems on both
> Android and Chrome OS, and this fix has already been included in a
> number of ext4 encryption backports.]
>
> We don't want the writeback triggered from the journal commit (in
> data=writeback mode) to cause the journal to abort due to
> generic_writepages() returning an ENOMEM error. In addition, if
> fsync() fails with ENOMEM, most applications will probably not do the
> right thing.
>
> So if we are doing a data integrity sync, and ext4_encrypt() returns
> ENOMEM, we will submit any queued I/O to date, and then retry the
> allocation using GFP_NOFAIL.
>
> Google-Bug-Id: 27641567
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thanks for both of these, now queued up.
greg k-h
prev parent reply other threads:[~2017-05-23 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 23:37 [PATCH 1/2] ext4 crypto: don't let data integrity writebacks fail with ENOMEM Eric Biggers
2017-05-22 23:37 ` [PATCH 2/2] ext4 crypto: fix some error handling Eric Biggers
2017-05-23 10:13 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523101344.GA28565@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).