From: Greg KH <gregkh@linuxfoundation.org>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: linux-stable <stable@vger.kernel.org>
Subject: Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()
Date: Sat, 27 May 2017 22:26:29 +0200 [thread overview]
Message-ID: <20170527202629.GA16472@kroah.com> (raw)
In-Reply-To: <B9839FA4-B361-4983-87E1-5F6BF9CCA6AD@linuxhacker.ru>
On Sat, May 27, 2017 at 03:22:18PM -0400, Oleg Drokin wrote:
> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
> lov_user_md pointer from user- or kernel-space. This changes the
> behavior of copy_from_user() on SPARC and may result in a misaligned
> access exception which in turn oopses the kernel. In fact the
> relevant argument to lov_getstripe() is never called with a
> kernel-space pointer and so changing the address limits is unnecessary
> and so we remove the calls to save, set, and restore the address
> limits.
>
> Signed-off-by: John L. Hammond <john.hammond@intel.com>
> Reviewed-on: http://review.whamcloud.com/6150
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221
> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> Reviewed-by: Li Wei <wei.g.li@intel.com>
> CC: linux-stable <stable@vger.kernel.org> # >= v3.11
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> ---
> drivers/staging/lustre/lustre/lov/lov_pack.c | 9 ---------
> 1 file changed, 9 deletions(-)
What was the git commit id of this patch in Linus's tree?
thanks,
greg k-h
next prev parent reply other threads:[~2017-05-27 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 19:22 [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe() Oleg Drokin
2017-05-27 20:26 ` Greg KH [this message]
2017-05-27 22:38 ` Oleg Drokin
2017-05-28 5:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170527202629.GA16472@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=green@linuxhacker.ru \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).